Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove restriction that route must start with /api to use api auth #58351

Merged
merged 2 commits into from
Feb 24, 2020
Merged

Remove restriction that route must start with /api to use api auth #58351

merged 2 commits into from
Feb 24, 2020

Conversation

kobelb
Copy link
Contributor

@kobelb kobelb commented Feb 24, 2020

No description provided.

@kobelb kobelb mentioned this pull request Feb 24, 2020
Merged
3 tasks
@kobelb kobelb added v7.7.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Feb 24, 2020
@kobelb kobelb requested a review from legrego February 24, 2020 17:39
@kobelb kobelb marked this pull request as ready for review February 24, 2020 17:39
@kobelb kobelb requested a review from a team as a code owner February 24, 2020 17:39
@kobelb
Copy link
Contributor Author

kobelb commented Feb 24, 2020

@elasticmachine merge upstream

legrego
legrego approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green CI

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kobelb kobelb merged commit 77fe83e into elastic:master Feb 24, 2020
@kobelb kobelb deleted the remove-auth-route-prefix branch February 24, 2020 21:04
kobelb added a commit to kobelb/kibana that referenced this pull request Feb 24, 2020
@kobelb @elasticmachine
Remove restriction that route must start with /api to use api autho…
d4a68b1 
…rization (elastic#58351)

Co-authored-by: Elastic Machine <[email protected]>
@kobelb kobelb mentioned this pull request Feb 24, 2020
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 25, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kobelb added a commit that referenced this pull request Feb 25, 2020
@kobelb @elasticmachine
Remove restriction that route must start with /api to use api autho…
78b1588 
…rization (#58351) (#58409)

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legrego legrego legrego approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kobelb @kibanamachine @legrego @elasticmachine