Functional tests: Fix saved object management button click retry #58218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Flaky test run here: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/196 |
flash1293
added
release_note:skip
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
majagrubic
approved these changes
Feb 25, 2020
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Feb 26, 2020
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Feb 26, 2020
flash1293
added a commit
that referenced
this pull request
Feb 26, 2020
flash1293
added a commit
that referenced
this pull request
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45348
The saved object management page object contains a retry loop to make sure the modal opens correctly (because this is sometimes flaky).
However within the retry loop, the check whether the modal is already loaded has itself an internal retry logic with a very long timeout (just as long as the timeout for the outer explicit retry). This means if the first try doesn't succeed, it won't get to the second run because the check condition takes so long the outer retry times out.
This PPR changes the timeout of the inner retry to 2500 ms wheres the outer retry still runs with 120000ms.