Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIEM] Create ML Rules #58053
[SIEM] Create ML Rules #58053
Changes from 62 commits
a61dd5e
5843a9a
34bf432
56a0766
0b19ddc
28ede95
bec1a90
d9639af
190c7bb
919dfef
051f638
7ae29bf
6b25593
d5b03a2
82093ce
bb8abc2
526e8a3
a5d05e0
75eaa12
68cbf21
7a62dba
31ac415
26822eb
7434bcb
fb7c5f1
cec8075
b80d5d0
05d4dda
79d9cb4
5424746
a689d33
9cb88c7
85678cb
316a720
2cd97f1
23532ab
41e5af1
0a8caf0
9aca40c
330cc0c
92f9c57
addc6ac
0ca3858
190600c
a683ef5
94c1774
327a877
e85feb5
e80dd2c
5e85c7e
eed90df
abfcfc1
f0a1f0f
e703568
8ff89b0
edf354e
a949ce5
1f1b9e9
cf8d8c3
f692e01
1aa4321
8ff01e9
16b25d1
b4fd572
462d410
9f9f324
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be better as just an unsafe cast rather than lodash get for a refactor like so:
It would be cleaner and if/when you have the io-ts type you can run a decode on it and handle a left and a right with the decode for more run time safety to do maybe a throw error if a maintainer messes it up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deferred to #60567
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woa...This is very abnormal code flow you are refactoring here.
It checks if it is an array rather than a field value part way down but not the the field switch?
This is going to make future changes brittle and error prone depending on where we add the field value. I would ask you do us all a favor and add what the field value is through a call of:
That might not even be getting touched? It is really hard to understand code the more I look at it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deferred to #60567