Migrate home app #58030

flash1293 · 2020-02-19T16:38:13Z

This PR moves the home app over into the new platform. The only thing being left behind are static resources which are currently not supported by the new platform, those will be moved in a separate PR once the core api is available.

This PR also removes some exposed apis which were only necessary to pass information from the NP home plugin to the legacy home plugin.

elasticmachine · 2020-02-21T17:58:34Z

Pinging @elastic/kibana-app (Team:KibanaApp)

flash1293 · 2020-02-24T09:35:53Z

@elasticmachine merge upstream

kertal · 2020-02-24T10:57:52Z

just started to test it, seems there's a problem when you click on "Add Apm"

Same error with other tutorials like
http://localhost:5601/aft/app/kibana#/home/tutorial/apacheLogs

flash1293 · 2020-02-24T11:42:09Z

Thanks for checking @kertal , seems like there are some imports of. I will check and fix 👍

afgomez

infra changes lgtm

…te-home

cchaos · 2020-03-02T15:03:41Z

src/legacy/core_plugins/kibana/public/index.scss

 // Visualize styles
 @import './visualize/index';
 // Has to come after visualize because of some
 // bad cascading in the Editor layout
 @import 'src/legacy/ui/public/vis/index';

+// Home styles
+@import '../../../../plugins/home/public/application/index';


Can you import this file directly in the JS in plugins/home/public/ instead?

And also then rename it from _index.scss to index.scss

I originally included this but reverted because the scss is depending on legacy mixins in “ui/styles”. Importing from a module in the new platform gave me an error. The platform team is owning the topic and is tracking this separately, as soon as it’s moved the entry-point can be moved over just as you suggest.

You could then just import the mixin dependencies directly in the index.scss file so as to unblock moving this to the JS file.

It’s not complaining about the mixin itself (somehow it’s pulling that in implicitly), but about an asset used within the mixin: https://github.com/elastic/kibana/blob/master/src/legacy/ui/public/styles/_mixins.scss#L92

That’s the line failing. As it’s going to get migrated soon I didn’t dig any deeper , but maybe you know a better way around the problem.

What does the error say?

Also, I wonder then why yours would be the only implementation that complains if it's not the one pulling the file directly...

I couldn't reproduce the problem locally anymore and the Jenkins build with this failure is already cleaned up - I committed the change again, if it works even better.

Also, I wonder then why yours would be the only implementation that complains if it's not the one pulling the file directly...

There is no usage of that specific mixin from within the new platform so far, it's only consumed the legacy way:

x-pack/plugins/spaces/public/space_selector/_space_selector.scss 2: @include kibanaFullScreenGraphics; x-pack/legacy/plugins/security/public/components/authentication_state_page/_authentication_state_page.scss 2: @include kibanaFullScreenGraphics; x-pack/legacy/plugins/security/public/views/login/components/login_page/_login_page.scss 2: @include kibanaFullScreenGraphics; src/plugins/home/public/application/components/_welcome.scss 2: @include kibanaFullScreenGraphics($euiZLevel6);

Spaces selector looks like it's imported in the new platform, but it's still used in the old way eventually: x-pack/legacy/plugins/spaces/public/index.scss

I just pulled down your branch, ran it locally, didn't get any compile or console errors and the graphics rendered properly in the Welcome page. So... 👍 looks like all is good with the import in JS?

flash1293 · 2020-03-02T19:20:15Z

@kertal This PR should be ready to be checked again from the JS side of things - fixed the broken tutorials.

kertal

Code LGTM, waving goodbye to home from legacy world, may the static assets follow soon.
No more JS problems detected, tested locally in chrome!

flash1293 · 2020-03-03T05:38:30Z

@cchaos That’s the build failure I was referring to:
Module not found: Error: Can't resolve './ui/assets/images/bg_bottom_branded.svg' in '/dev/shm/workspace/kibana/build/kibana-oss/src/plugins/home/public/application'

Do you have an idea what this is about?

lizozom · 2020-03-03T10:18:52Z

src/plugins/home/public/index.ts

@@ -21,13 +21,9 @@ import { PluginInitializerContext } from 'kibana/public';

 export {
  FeatureCatalogueSetup,


If you're exposing only the setup contract of these sub-services, maybe expose them as FeatureCatalogueSetup as FeatureCatalogue?

Good point, I will fix that

flash1293 · 2020-03-03T10:27:45Z

src/plugins/home/public/services/feature_catalogue/feature_catalogue_registry.ts

+    this.capabilities = capabilities;
+  }
+
+  public get(): readonly FeatureCatalogueEntry[] {


It was exposed because the home app was still part of the legacy platform while the registry already moved. Now both are back together in a single plugin and there is no need anymore to expose that information.

flash1293 · 2020-03-03T10:27:45Z

src/plugins/home/public/services/feature_catalogue/feature_catalogue_registry.ts

+    this.capabilities = capabilities;
+  }
+
+  public get(): readonly FeatureCatalogueEntry[] {


It was exposed because the home app was still part of the legacy platform while the registry already moved. Now both are back together in a single plugin and there is no need anymore to expose that information.

lizozom

Added one minor comment

flash1293 · 2020-03-03T18:33:10Z

@cchaos as discussed offline, I reverted the new platform scss import for now.

flash1293 · 2020-03-03T20:38:41Z

Jenkins, test this.

kibanamachine · 2020-03-03T22:37:49Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 9ef44aa

History

💔 Build #30466 failed 9ef44aa
💔 Build #30180 failed 02340e8
💚 Build #29992 succeeded 6b5f0e6
💔 Build #28394 failed 9363c5a
💔 Build #28385 failed 9363c5a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

flash1293 added 7 commits February 18, 2020 13:15

remove injected reference from home app

38f6cc4

fix home plugin mocks

34eb369

Merge remote-tracking branch 'upstream/master' into de-cloud-home

c47b753

Merge branch 'de-cloud-home' into migrate-home

ac80731

migrate home plugin

80a5194

Merge remote-tracking branch 'upstream/master' into migrate-home

bd45e74

fix test failures

a49d768

flash1293 added Feature:Home Kibana home application v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:NP Migration v7.7.0 labels Feb 19, 2020

flash1293 added 6 commits February 20, 2020 14:09

Merge remote-tracking branch 'upstream/master' into migrate-home

b8a23f9

fix type errors

d508e85

Merge remote-tracking branch 'upstream/master' into migrate-home

335e587

fix i18n ids

d029823

Merge remote-tracking branch 'upstream/master' into migrate-home

2722e0e

nomve home styles back for now

a122c8f

flash1293 marked this pull request as ready for review February 21, 2020 17:57

flash1293 requested a review from a team February 21, 2020 17:57

flash1293 requested review from a team as code owners February 21, 2020 17:57

flash1293 added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Feb 21, 2020

Merge branch 'master' into migrate-home

9363c5a

afgomez approved these changes Feb 25, 2020

View reviewed changes

flash1293 added 3 commits March 2, 2020 09:31

Merge remote-tracking branch 'upstream/master' into migrate-home

17b50f9

fix migrated home app

7a68c39

Merge branch 'migrate-home' of github.com:flash1293/kibana into migra…

6b5f0e6

…te-home

flash1293 requested a review from a team as a code owner March 2, 2020 09:48

cchaos suggested changes Mar 2, 2020

View reviewed changes

import scss from new platform

02340e8

kertal approved these changes Mar 2, 2020

View reviewed changes

lizozom reviewed Mar 3, 2020

View reviewed changes

flash1293 commented Mar 3, 2020

View reviewed changes

lizozom approved these changes Mar 3, 2020

View reviewed changes

flash1293 added 2 commits March 3, 2020 19:29

Merge remote-tracking branch 'upstream/master' into migrate-home

10211ae

revert new platform scss import

9ef44aa

cchaos approved these changes Mar 3, 2020

View reviewed changes

flash1293 merged commit cba4f34 into elastic:master Mar 4, 2020

flash1293 added a commit to flash1293/kibana that referenced this pull request Mar 4, 2020

Migrate home app (elastic#58030)

5e98718

flash1293 mentioned this pull request Mar 4, 2020

[7.x] Migrate home app (#58030) #59273

Merged

flash1293 added a commit that referenced this pull request Mar 4, 2020

Migrate home app (#58030) (#59273)

db4a61b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate home app #58030

Migrate home app #58030

flash1293 commented Feb 19, 2020

elasticmachine commented Feb 21, 2020

flash1293 commented Feb 24, 2020

kertal commented Feb 24, 2020

flash1293 commented Feb 24, 2020

afgomez left a comment

cchaos Mar 2, 2020

cchaos Mar 2, 2020

flash1293 Mar 2, 2020

cchaos Mar 2, 2020

flash1293 Mar 2, 2020

cchaos Mar 2, 2020

cchaos Mar 2, 2020

flash1293 Mar 2, 2020

cchaos Mar 2, 2020

flash1293 commented Mar 2, 2020

kertal left a comment

flash1293 commented Mar 3, 2020 •

edited

Loading

lizozom Mar 3, 2020 •

edited

Loading

flash1293 Mar 3, 2020

flash1293 Mar 3, 2020

flash1293 Mar 3, 2020

lizozom left a comment

flash1293 commented Mar 3, 2020

flash1293 commented Mar 3, 2020

kibanamachine commented Mar 3, 2020

		@@ -21,13 +21,9 @@ import { PluginInitializerContext } from 'kibana/public';

		export {
		FeatureCatalogueSetup,

Migrate home app #58030

Migrate home app #58030

Conversation

flash1293 commented Feb 19, 2020

elasticmachine commented Feb 21, 2020

flash1293 commented Feb 24, 2020

kertal commented Feb 24, 2020

flash1293 commented Feb 24, 2020

afgomez left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flash1293 commented Mar 2, 2020

kertal left a comment

Choose a reason for hiding this comment

flash1293 commented Mar 3, 2020 • edited Loading

lizozom Mar 3, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lizozom left a comment

Choose a reason for hiding this comment

flash1293 commented Mar 3, 2020

flash1293 commented Mar 3, 2020

kibanamachine commented Mar 3, 2020

💚 Build Succeeded

History

flash1293 commented Mar 3, 2020 •

edited

Loading

lizozom Mar 3, 2020 •

edited

Loading