Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs / Metrics UI] Add "enabled" key schema validation #57935

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

Kerry350
Copy link
Contributor

@Kerry350 Kerry350 commented Feb 18, 2020

Summary

Adds xpack.infra.enabled config validation. This was incorrectly removed by me as I misinterpreted some information in the docs.

To test this: Adding xpack.infra.enabled: false to your config should not cause an error when starting Kibana.

@Kerry350 Kerry350 added v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Feb 18, 2020
@Kerry350 Kerry350 requested a review from a team February 18, 2020 22:59
@Kerry350 Kerry350 self-assigned this Feb 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Kerry350 Kerry350 merged commit a4d8bc8 into elastic:master Feb 19, 2020
Kerry350 added a commit to Kerry350/kibana that referenced this pull request Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants