[ML] New Platform server shim: update job audit messages routes #57925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
:ml
v8.0.0
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
78 tasks
walterra
approved these changes
Feb 19, 2020
Comment on lines
12
to
13
| getJobAuditMessages: (jobId: string | undefined, from: string | undefined) => any; | ||
| getAuditMessagesSummary: (jobIds: string[] | undefined) => any; |
There was a problem hiding this comment.
Nit: Could make use of optional parameters like (jobId?: string, from?: string) and (jobIds?: string[]).
jgowdyelastic
approved these changes
Feb 19, 2020
| context.ml!.mlClient.callAsCurrentUser | ||
| ); | ||
| const { jobId } = request.params; | ||
| const from = request.query.from; |
There was a problem hiding this comment.
absolute nit, could be const { from } = request.query;
it stands out be cause if the line above it
alvarezmelissa87
force-pushed
the
ml-np-job-audit-message-routes
branch
from
f1eb404 to
dcb7a1d
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Feb 19, 2020
…tic#57925) * migrate all job audit messages routes to NP * update types and add missing api names from validation
alvarezmelissa87
added a commit
that referenced
this pull request
Feb 19, 2020
…) (#58041) * migrate all job audit messages routes to NP * update types and add missing api names from validation
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Feb 20, 2020
* master: (136 commits) [Visualize] Remove legacy appState in visualize (elastic#57330) Use static time for tsvb rollup test (elastic#57701) [SIEM] Fix ResizeObserver polyfill (elastic#58046) [SIEM][Detection Engine] Fixes return codes where some were rule_id instead of id skip flaky suite (elastic#56816) skip flaky suite (elastic#58059) skip flaky suite (elastic#45348) migrates notification server routes to NP (elastic#57906) Moved all of the show/hide toggles outside of ordered lists. (elastic#57163) [APM] NP Migration - Moves plugin server files out of legacy (elastic#57532) [Maps][Telemetry] Migrate Maps telemetry to NP (elastic#55055) Embeddable add panel examples (elastic#57319) Fix useRequest to support query change (elastic#57723) Allow custom paths in plugin generator (elastic#57766) [SIEM][Case] Merge header components (elastic#57816) [ML] New Platform server shim: update job audit messages routes (elastic#57925) [kbn/optimizer] emit success event from reducer when all bundles cached (elastic#57945) [APM] Don’t include UI filters when fetching a specific transaction (elastic#57934) Upgrade yargs (elastic#57720) skip flaky suite (elastic#57762) (elastic#57997) (elastic#57998) ... # Conflicts: # src/plugins/advanced_settings/public/management_app/components/field/__snapshots__/field.test.tsx.snap # src/plugins/advanced_settings/public/management_app/components/field/field.tsx # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related meta issue: #49743
Updates all job audit messages routes to use new platform router
Checklist
Delete any items that are not applicable to this PR.