Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Fix failing snapshot link functional test in cloud env #57884

Merged

Conversation

kertal
Copy link
Member

@kertal kertal commented Feb 18, 2020

Summary

Fix failing cloud test: discover app shared links shared links with state in sessionStorage permalink should allow for copying the snapshot URL as a short URL and should open it

Fixes #55777

@kertal kertal added Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v7.7.0 v7.6.1 labels Feb 18, 2020
@kertal kertal self-assigned this Feb 18, 2020
@kertal kertal requested a review from liza-mae February 18, 2020 16:49
@kertal kertal added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Feb 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Copy link
Contributor

@liza-mae liza-mae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kertal kertal merged commit 02e0903 into elastic:master Feb 19, 2020
kertal added a commit to kertal/kibana that referenced this pull request Feb 19, 2020
kertal added a commit to kertal/kibana that referenced this pull request Feb 19, 2020
kertal added a commit that referenced this pull request Feb 19, 2020
kertal added a commit that referenced this pull request Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure test-cloud v7.6.1 v7.7.0 v8.0.0
Projects
None yet
4 participants