Test NP logging config reload on SIGHUP #57681
Conversation
mshustov
added
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
mshustov
added
chore
v7.7.0
v8.0.0
release_note:skip
|
@elasticmachine merge upstream |
mshustov
changed the title
|
The old test was not skipped before, so it must have been passing, however we know the feature is/was broken. Do we know why it was passing? A quick scan of the old test looks like it may not have been reopening the file handle? |
I think so. "Broken" means that Kibana writes in both new and old log files simultaneously. The current test is a smoke test verifying the logging system manages a new destination after SIGHUP. |
|
|
||
| if (matcher.test(contents)) { | ||
| clearTimeout(timeoutHandle); | ||
| Fs.unwatchFile(path); |
There was a problem hiding this comment.
nit: you could move this to a finally on the outer promise
| ); | ||
|
|
||
| it( | ||
| 'should recreate file handler on SIGHUP', |
There was a problem hiding this comment.
nit:
| 'should recreate file handler on SIGHUP', | |
| 'should recreate file handle on SIGHUP', |
| 30 * second | ||
| ); | ||
| it( | ||
| 'should recreate file handler on SIGHUP', |
There was a problem hiding this comment.
nit:
| 'should recreate file handler on SIGHUP', | |
| 'should recreate file handle on SIGHUP', |
mshustov
force-pushed
the
reload-np-logging-config
branch
from
0f2c0bf to
4d7cbb1
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* TSify reload config test and simplify logic * get rid of mutable config in tests * increase timeouts * address comments
|
I have noticed a few timeouts in the jest integration tests in the last couple days, trying to track down what's causing them in #58543 but I suspect this PR |
Summary
Refactored tests for LP getting rid of mutability, it should slightly improve readability.
Added similar tests for the NP logging config.
For maintainers