[Reporting] Unit test for screenshot observable #57638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
force-pushed
the
reporting/test-screenshot-pipe
branch
from
5511db0 to
133bcf6
Compare
commit 1c6a6b0 Author: Timothy Sullivan <[email protected]> Date: Thu Feb 13 14:10:40 2020 -0700 fix tests commit a3afefd Merge: facd94b 6e4efdf Author: Timothy Sullivan <[email protected]> Date: Thu Feb 13 13:56:24 2020 -0700 Merge branch 'master' into reporting/np-server-uisettings commit facd94b Author: Timothy Sullivan <[email protected]> Date: Thu Feb 13 12:16:51 2020 -0700 extract internals access to separate core class commit 2f12495 Merge: dd0fd40 3f3969d Author: Timothy Sullivan <[email protected]> Date: Thu Feb 13 09:57:07 2020 -0700 Merge branch 'master' into reporting/np-server-uisettings commit dd0fd40 Author: Timothy Sullivan <[email protected]> Date: Wed Feb 12 14:44:03 2020 -0700 add more tests commit 25dc761 Author: Timothy Sullivan <[email protected]> Date: Wed Feb 12 13:54:47 2020 -0700 simplify reporting usage collector setup commit e8aa02d Author: Timothy Sullivan <[email protected]> Date: Wed Feb 12 13:44:13 2020 -0700 consistent name for reportingPlugin commit d235b16 Author: Timothy Sullivan <[email protected]> Date: Wed Feb 12 13:52:07 2020 -0700 Prettier changes commit e8ddc7b Author: Timothy Sullivan <[email protected]> Date: Wed Feb 12 13:28:35 2020 -0700 [Reporting/New Platform] Provide async access to server-side
tsullivan
force-pushed
the
reporting/test-screenshot-pipe
branch
from
133bcf6 to
24ea6b3
Compare
tsullivan
added
(Deprecated) Feature:Reporting
tsullivan
added
the
release_note:skip
tsullivan
commented
Feb 18, 2020
| @@ -4,48 +4,55 @@ | |||
| * you may not use this file except in compliance with the Elastic License. | |||
| */ | |||
|
|
|||
| import { HeadlessChromiumDriver as HeadlessBrowser } from '../../../../server/browsers/chromium/driver'; | |||
| import { HeadlessChromiumDriver as HeadlessBrowser } from '../../../../server/browsers'; | |||
There was a problem hiding this comment.
This one, and the next 3 files have a lot of whitespace changes enforced by prettier. It would help to ignore whitespace changes in this PR review :)
tsullivan
commented
Feb 18, 2020
| }).toPromise(); | ||
| }; | ||
|
|
||
| await expect(getScreenshot()).rejects.toMatchInlineSnapshot( |
There was a problem hiding this comment.
NOTE: This part of assertions will change when #57008 is implemented
| @@ -0,0 +1,129 @@ | |||
| /* | |||
There was a problem hiding this comment.
Whew this is a fun one
There was a problem hiding this comment.
Yeah.. I think this test and the way things are mocked, especially in createPage highlight some overly-complicated areas of Reporting and maybe things that have real performance impact.
tsullivan
commented
Feb 18, 2020
x-pack/legacy/plugins/reporting/export_types/common/lib/screenshots/skip_telemetry.ts
Outdated
Show resolved
Hide resolved
joelgriffith
approved these changes
Feb 18, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Feb 18, 2020
[Reporting] test the screenshot observable
tsullivan
added a commit
that referenced
this pull request
Feb 19, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a suite of unit tests to the
screenshotsObservableFactorymethod of Kibana Reporting.Related to the fix from #56928