[Draft][wip] Adding storybook static site generation and percy storybook script #57628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poffdeluxe
commented
Feb 13, 2020
packages/kbn-storybook/index.js
Outdated
| }); | ||
|
|
||
| // Line is only reached when building the static version | ||
| process.exit(); |
There was a problem hiding this comment.
I don't love this. I went with it because I was having issues with this CLI tool continuing to run despite the storybook promise resolving (and I disabled the --watch on the sass watcher too). There's probably something I'm missing.
poffdeluxe
commented
Feb 13, 2020
| @@ -27,7 +27,7 @@ import { create } from '@storybook/theming'; | |||
| if (process.env.NODE_ENV === 'test') { | |||
| // eslint-disable-next-line | |||
| require('babel-plugin-require-context-hook/register')(); | |||
| } else { | |||
| } else if (!process.env.PERCY_TOKEN) { | |||
There was a problem hiding this comment.
I don't love this either. We're deciding not to add all the storybook decorations if we have a PERCY_TOKEN defined in the environment. I couldn't find a great way to pass in flags to a storybook config but I'm def open to other suggestions
streamich
approved these changes
Feb 14, 2020
streamich
reviewed
Feb 19, 2020
This was referenced Feb 19, 2020
Closed
Co-Authored-By: Vadim Dalecky <[email protected]>
poffdeluxe
force-pushed
the
percy-storybook
branch
from
f39c90c to
6183463
Compare
poffdeluxe
force-pushed
the
percy-storybook
branch
from
6183463 to
1387297
Compare
|
Going to re-open once #58050 is merged |
💔 Build FailedTest FailuresKibana Pipeline / kibana-oss-agent / Firefox UI Functional Tests.test/functional/apps/visualize/_tsvb_chart·ts.visualize app visual builder switch index patterns "before each" hook for "should be able to switch between index patterns"Standard OutStack TraceKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/index_patterns/feature_controls/index_patterns_spaces·ts.Index Patterns feature controls spaces space with Index Patterns disabled redirects to Kibana homeStandard OutStack TraceKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/advanced_settings/feature_controls/advanced_settings_security·ts.Advanced Settings security feature controls no advanced_settings privileges does not allow navigation to advanced settings; redirects to management homeStandard OutStack Traceand 1 more failures, only showing the first 3. History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--siteflagAn example of the percy-storybook run can be found here running using Canvas stories: https://percy.io/elastic/kibana-canvas/builds/4154578
TODO