-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] NP Migration - Saved Objects Client #57438
[APM] NP Migration - Saved Objects Client #57438
Conversation
and context scoped clients exposed in the new platform core setup
const apmIndices = await framework.plugins.apm.getApmIndices( | ||
requestContext.core.savedObjects.client | ||
); | ||
const apmIndices = await framework.plugins.apm.getApmIndices(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
infra changes LGTM, thanks!
@elasticmachine merge upstream |
💔 Build FailedTest FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/advanced_settings/feature_controls/advanced_settings_security·ts.Advanced Settings security feature controls no advanced_settings privileges does not allow navigation to advanced settings; redirects to management homeStandard Out
Stack Trace
Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/rollup_job/tsvb·js.rollup app tsvb integration create rollup tsvbStandard Out
Stack Trace
Kibana Pipeline / kibana-xpack-agent / X-Pack API Integration Tests.x-pack/test/api_integration/apis/apm/feature_controls·ts.apis APM apm feature controls spaces user_1 can access APIs in space_1Standard Out
Stack Trace
and 2 more failures, only showing the first 3. History
To update your PR or re-run it, just comment with: |
Closing this since it's already part of another PR: #57532 |
Closes #56832
Migrates uses of the saved objects client to the internal and context scoped clients exposed in the new platform core setup.