[SIEM] Fixes Host Details Events Table to only show events for specified Host

[spong]

Summary

Fixes an issue where the Events Table on the Host Details page would show all events instead of those for the specific host. Also adds tests to make sure this doesn't happen again 🙂

Note: This will not interfere with any user-added queries/filters as those are added separately.

Before / After (See Event count at bottom of image)

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• This was checked for keyboard-only and screenreader accessibility
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
• This was checked for cross-browser compatibility, including a check against IE11

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/siem (Team:SIEM)

[FrankHassanabad]

👍 Thanks for the test!

[FrankHassanabad]

Optionally you can do this trick:

    it('correctly constructs pageFilters for the given hostName', () => {
      const expected: esFilters.Filter[] = [
        {
          meta: {
            alias: null,
            negate: false,
            disabled: false,
            type: 'phrase',
            key: 'host.name',
            value: 'host-1',
            params: {
              query: 'host-1',
            },
          },
          query: {
            match: {
              'host.name': {
                query: 'host-1',
                type: 'phrase',
              },
            },
          },
        },
      ];
      expect(getHostDetailsPageFilters('host-1')).toEqual(expected);

And if that type ever changes your type script will blow up before the test does and ensure that your expected type here always matches your filter type.

[spong]

Ooh nice little improvement there -- thanks @FrankHassanabad! I've made the change and will take this little tidbit with me going forward 🙂

[FrankHassanabad]

LGTM, checked it out, tested it and left some feedback.

Overall works as advertised and is a good fix. Would highly recommend ++ AAA rating

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 1dc2c04

History

• 💚 Build #26054 succeeded 363b340

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream