[Maps] only request field in docvalue_fields when the field supports doc values #57372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
release_note:fix
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
x-pack/legacy/plugins/maps/public/layers/sources/es_search_source/es_search_source.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/sources/es_search_source/es_search_source.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/sources/es_search_source/es_search_source.js
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
thomasneirynck
approved these changes
Feb 18, 2020
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Feb 18, 2020
…doc values (elastic#57372) * [Maps] only request field in docvalue_fields when the field supports doc values * do not include scripted fields in sourceOnlyFields * review feedback Co-authored-by: Elastic Machine <[email protected]>
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Feb 18, 2020
…doc values (elastic#57372) * [Maps] only request field in docvalue_fields when the field supports doc values * do not include scripted fields in sourceOnlyFields * review feedback Co-authored-by: Elastic Machine <[email protected]>
nreese
added a commit
that referenced
this pull request
Feb 18, 2020
…doc values (#57372) (#57873) * [Maps] only request field in docvalue_fields when the field supports doc values * do not include scripted fields in sourceOnlyFields * review feedback Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
nreese
added a commit
that referenced
this pull request
Feb 18, 2020
…doc values (#57372) (#57872) * [Maps] only request field in docvalue_fields when the field supports doc values * do not include scripted fields in sourceOnlyFields * review feedback Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56419
Categorical styling combined with geo_shape documents exposed some bugs in the way ESSearchSource generated the
_searchbody. This PR removes all of the hard coded geo_point and geo_shape logic and instead just checks each field to see if the field supports doc_values. If the field supports doc_values then its retrieved fromdocvalue_fields. If the field does not support doc_values then its retrieved from_source.