[ML] New Platform server shim: update file data visualizer routes to use new platform router #56972

darnautov · 2020-02-06T12:34:33Z

Summary

Part of #49743. Updates file data visualizer analyze route to use the new platform router. Also replaces the import endpoint call with the file upload plugin, as per #35947.

Checklist

Documentation was added for features that require explanation or tutorials
This was checked for cross-browser compatibility, including a check against IE11

…alyzer endpoint

elasticmachine · 2020-02-06T12:34:36Z

Pinging @elastic/ml-ui (:ml)

jgowdyelastic

Added a couple of comments, but generally the code LGTM.

x-pack/legacy/plugins/ml/server/models/file_data_visualizer/file_data_visualizer.ts

peteharverson · 2020-02-06T16:56:05Z

x-pack/legacy/plugins/ml/public/application/services/ml_api_service/datavisualizer.js

@@ -33,7 +33,7 @@ export const fileDatavisualizer = {
    const { index, data, settings, mappings, ingestPipeline } = obj;

    return http({
-      url: `${basePath}/file_data_visualizer/import${paramString}`,
+      url: `${basePath}/fileupload/import${paramString}`,


Switching to the fileupload route for the import means we are losing the telemetry on the count of indexes created by the ML file data visualizer, which was done by a call to incrementFileDataVisualizerIndexCreationCount in /ml/server/lib/ml_telemetry/ml_telemetry.ts. We need to keep the telemetry part of the import, but get the file upload plugin to do the actual file import.

elasticmachine · 2020-02-07T14:02:26Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 0bfcb34

History

💚 Build #24911 succeeded e5e6098
💚 Build #24894 succeeded a4fe581

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

elasticmachine · 2020-02-07T15:04:37Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 6444aff

History

💚 Build #25225 succeeded 0bfcb34
💚 Build #24911 succeeded e5e6098
💚 Build #24894 succeeded a4fe581

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…s' into ML-49743-fileDataVisualizerRoutes

jgowdyelastic

LGTM

peteharverson

Tested latest changes and LGTM.

darnautov · 2020-02-07T17:34:21Z

@elasticmachine merge upstream

kibanamachine · 2020-02-07T18:58:47Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 61d55af

History

💔 Build #25283 failed c0eb6ff
💚 Build #25240 succeeded 6444aff
💚 Build #25225 succeeded 0bfcb34
💚 Build #24911 succeeded e5e6098
💚 Build #24894 succeeded a4fe581

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…use new platform router (elastic#56972) * [ML] change import endpoint call to fileupload plugin, update file analyzer endpoint * [ML] add apiDoc annotation * [ML] AnalysisResult interface, remove url from apidoc.json * [ML] delete import_data.js * [ML] remove caching code, address PR comments * [ML] file import * [ML] apidoc * [ML] schema validation Co-authored-by: Elastic Machine <[email protected]>

…use new platform router (#56972) (#57167) * [ML] change import endpoint call to fileupload plugin, update file analyzer endpoint * [ML] add apiDoc annotation * [ML] AnalysisResult interface, remove url from apidoc.json * [ML] delete import_data.js * [ML] remove caching code, address PR comments * [ML] file import * [ML] apidoc * [ML] schema validation Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>

…t-state * upstream/master: (96 commits) top nav ts arg support (elastic#56984) [SIEM][detection engine] Limit network rules to filebeat source semantics (elastic#57130) Add docs for alerting and action settings (elastic#57035) Add Test to Verify Endpoint App Landing Page (elastic#57129) Update `markdown-to-jsx` (`6.9.3` → `6.11.0`) and `url-parse` (`1.4.4` → `1.4.7`) dependencies. (elastic#57126) chore(NA): removes use of parallel option in the terser minimizer (elastic#57077) [ML] New Platform server shim: update file data visualizer routes to use new platform router (elastic#56972) Specifying valid licenses for the Graph feature (elastic#55911) [APM][docs] Add troubleshooting for non-indexed fields (elastic#54948) [ML] DF Analytics creation: update schema definition for create route (elastic#56979) Remove Kibana a11y guide in favor of EUI (elastic#57021) [Logs UI] Set streamLive false in URL state when arriving from link-to (elastic#56329) [docs] Fix spaces api example json (elastic#50411) Add new config for filebeat index name (elastic#56920) [Metrics-UI] Fix toolbar popover for metrics table row (elastic#56796) Saved Objects testing (elastic#56965) Disabled categorization stats validation (elastic#57087) [Rollups] Server NP migration (elastic#55606) [Metrics UI] Limit group by selector to only 2 fields (elastic#56800) fix auto closing new vis modal when navigating to lens or when navigating away with browser history (elastic#56998) ...

* master: (96 commits) top nav ts arg support (elastic#56984) [SIEM][detection engine] Limit network rules to filebeat source semantics (elastic#57130) Add docs for alerting and action settings (elastic#57035) Add Test to Verify Endpoint App Landing Page (elastic#57129) Update `markdown-to-jsx` (`6.9.3` → `6.11.0`) and `url-parse` (`1.4.4` → `1.4.7`) dependencies. (elastic#57126) chore(NA): removes use of parallel option in the terser minimizer (elastic#57077) [ML] New Platform server shim: update file data visualizer routes to use new platform router (elastic#56972) Specifying valid licenses for the Graph feature (elastic#55911) [APM][docs] Add troubleshooting for non-indexed fields (elastic#54948) [ML] DF Analytics creation: update schema definition for create route (elastic#56979) Remove Kibana a11y guide in favor of EUI (elastic#57021) [Logs UI] Set streamLive false in URL state when arriving from link-to (elastic#56329) [docs] Fix spaces api example json (elastic#50411) Add new config for filebeat index name (elastic#56920) [Metrics-UI] Fix toolbar popover for metrics table row (elastic#56796) Saved Objects testing (elastic#56965) Disabled categorization stats validation (elastic#57087) [Rollups] Server NP migration (elastic#55606) [Metrics UI] Limit group by selector to only 2 fields (elastic#56800) fix auto closing new vis modal when navigating to lens or when navigating away with browser history (elastic#56998) ...

[ML] change import endpoint call to fileupload plugin, update file an…

a4fe581

…alyzer endpoint

darnautov added :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:File and Index Data Viz ML file and index data visualizer Feature:NP Migration v7.7.0 labels Feb 6, 2020

darnautov requested review from peteharverson and jgowdyelastic February 6, 2020 12:34

darnautov requested a review from a team as a code owner February 6, 2020 12:34

darnautov self-assigned this Feb 6, 2020

peteharverson mentioned this pull request Feb 6, 2020

[ML] New platform migration #49743

Closed

78 tasks

darnautov added 3 commits February 6, 2020 13:50

[ML] add apiDoc annotation

8f78c7f

[ML] AnalysisResult interface, remove url from apidoc.json

5630793

[ML] delete import_data.js

8c77b27

jgowdyelastic approved these changes Feb 6, 2020

View reviewed changes

x-pack/legacy/plugins/ml/server/models/file_data_visualizer/file_data_visualizer.ts Outdated Show resolved Hide resolved

x-pack/legacy/plugins/ml/server/models/file_data_visualizer/file_data_visualizer.ts Outdated Show resolved Hide resolved

[ML] remove caching code, address PR comments

e5e6098

jgowdyelastic self-requested a review February 6, 2020 15:40

peteharverson reviewed Feb 6, 2020

View reviewed changes

[ML] file import

5570202

darnautov requested a review from peteharverson February 7, 2020 12:26

darnautov added 2 commits February 7, 2020 13:37

[ML] apidoc

0bfcb34

Merge branch 'master' into ML-49743-fileDataVisualizerRoutes

6444aff

elastic deleted a comment from kibanamachine Feb 7, 2020

darnautov added 2 commits February 7, 2020 16:54

[ML] schema validation

ce85c3a

Merge remote-tracking branch 'origin/ML-49743-fileDataVisualizerRoute…

c0eb6ff

…s' into ML-49743-fileDataVisualizerRoutes

jgowdyelastic approved these changes Feb 7, 2020

View reviewed changes

peteharverson approved these changes Feb 7, 2020

View reviewed changes

Merge branch 'master' into ML-49743-fileDataVisualizerRoutes

61d55af

darnautov merged commit 4776cd9 into elastic:master Feb 7, 2020

darnautov deleted the ML-49743-fileDataVisualizerRoutes branch February 7, 2020 19:07

darnautov mentioned this pull request Feb 8, 2020

[7.x] [ML] New Platform server shim: update file data visualizer routes to use new platform router (#56972) #57167

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] New Platform server shim: update file data visualizer routes to use new platform router #56972

[ML] New Platform server shim: update file data visualizer routes to use new platform router #56972

darnautov commented Feb 6, 2020 •

edited by peteharverson

Loading

elasticmachine commented Feb 6, 2020

jgowdyelastic left a comment

peteharverson Feb 6, 2020

elasticmachine commented Feb 7, 2020

elasticmachine commented Feb 7, 2020

jgowdyelastic left a comment

peteharverson left a comment

darnautov commented Feb 7, 2020

kibanamachine commented Feb 7, 2020

[ML] New Platform server shim: update file data visualizer routes to use new platform router #56972

[ML] New Platform server shim: update file data visualizer routes to use new platform router #56972

Conversation

darnautov commented Feb 6, 2020 • edited by peteharverson Loading

Summary

Checklist

elasticmachine commented Feb 6, 2020

jgowdyelastic left a comment

Choose a reason for hiding this comment

peteharverson Feb 6, 2020

Choose a reason for hiding this comment

elasticmachine commented Feb 7, 2020

💚 Build Succeeded

History

elasticmachine commented Feb 7, 2020

💚 Build Succeeded

History

jgowdyelastic left a comment

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

darnautov commented Feb 7, 2020

kibanamachine commented Feb 7, 2020

💚 Build Succeeded

History

darnautov commented Feb 6, 2020 •

edited by peteharverson

Loading