Migrate existing Cypress tests to Cypress + Cucumber #56970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems not relevant to the main purpose of these tests
We are keeping cypress as rootDir to follow project's structure. On the other hand, having a second cypress directory at the 2nd level is the default structure, as shown in the examples: - https://github.com/TheBrainFamily/cypress-cucumber-webpack-typescript-example - https://github.com/cypress-io/cypress-example-recipes/tree/a240054d7f5626ffcd7bd668dded96d219c4a7eb/examples/preprocessors__typescript-webpack
It was automatically changed by tests
|
Pinging @elastic/apm-ui (Team:apm) |
|
@elasticmachine merge upstream |
mdelapenya
added
release_note:skip
v1v
approved these changes
Feb 6, 2020
mdelapenya
commented
Feb 6, 2020
Comment on lines
+1
to
+9
| Feature: APM | ||
|
|
||
| Background: | ||
| Given a user browses the APM UI application | ||
| When the user inspects the opbeans-go service | ||
|
|
||
| Scenario: Transaction duration charts | ||
| Then should redirect to correct path with correct params | ||
| And should have correct y-axis ticks |
There was a problem hiding this comment.
Hey @MadameSheema, I'd would love to get your insights about this spec 🙏 😊
|
@elasticmachine merge upstream |
💔 Build FailedHistory
To update your PR or re-run it, just comment with: |
Let's delegate dependency management to Kibana's build system
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💔 Build FailedHistory
To update your PR or re-run it, just comment with: |
|
After talking to @sqren, I'm going to close this PR and resend with following changes:
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It converts the existing Cypress tests for APM from Cypress to Cypress+Cucumber. To achieve that, it adds a cucumber-preprocessor, as shown in the following examples:
The cypress tests are run using the same
npm run cypress:runscript, so no CI command should be affected.As recommended by @elastic/kibana-operations, we moved the dependecies to
x-pack's package.json.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately