Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Adds a mini-init process for Docker #56866

Closed
wants to merge 1 commit into from

Conversation

tylersmalley
Copy link
Contributor

Based on elastic/elasticsearch#50277
Related to #52450

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich added the Team:Operations Team label for Operations Team label Feb 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@@ -120,7 +133,7 @@ function generator({
org.label-schema.build-date="${dockerBuildDate}" \\
license="${license}"

ENTRYPOINT ["/usr/local/bin/dumb-init", "--"]
ENTRYPOINT ["/tini", "--", "/usr/local/bin/dumb-init", "--"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there overlap between tini and dumb-init? should we remove dumb-init?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, totally spaced on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Operations Team label for Operations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants