Replace app state #56641
Closed
Replace app state #56641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
release_note:fix
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
PR opened against wrong branch. Closed and replaced with #56643 |
💔 Build FailedTo update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working to replace
AppStatein the Maps application I noticed 2 problems with howsavedQuerywere synced to the URL._aparameter does not havesavedQueryparameter, then adding one has not effect.This PR fixes these problems by causing
savedQueryService.getSavedQueryto throw when the saved object can not be loaded. The PR also changes the logic from$scope.savedQuery && isNewIdto!$scope.savedQuery || isNewId