Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify Security and EncryptedSavedObjects public contract names according to NP migration guide. #56597

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Unify Security and EncryptedSavedObjects public contract names according to NP migration guide. #56597

merged 1 commit into from
Feb 3, 2020

Conversation

azasypkin
Copy link
Member

Unify Security and EncryptedSavedObjects public contract names according to NP migration guide. Spaces plugin already follows the recommendation.

@azasypkin azasypkin added chore Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! release_note:skip Skip the PR/issue when compiling release notes Feature:NP Migration v7.7.0 labels Feb 3, 2020
@azasypkin azasypkin requested a review from a team as a code owner February 3, 2020 10:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

legrego
legrego approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks like some teams are missing CODEOWNER entries, since nobody else was pinged on this PR

@azasypkin
Copy link
Member Author

Looks like some teams are missing CODEOWNER entries, since nobody else was pinged on this PR

Hmm, yeah, will manually ping the most impacted team as well @elastic/kibana-alerting-services :)

@azasypkin azasypkin requested a review from mikecote February 3, 2020 12:46
mikecote
mikecote approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alerting and actions plugin changes LGTM! 👍

Strange on the missing ping for codeowners, will investigate.

@azasypkin azasypkin merged commit 8def60e into elastic:master Feb 3, 2020
@azasypkin azasypkin deleted the issue-xxx-unify-contract-name branch February 3, 2020 13:43
@azasypkin azasypkin mentioned this pull request Feb 3, 2020
Merged
@azasypkin
Copy link
Member Author

7.x/7.7.0: db68e41

jfsiii pushed a commit to jfsiii/kibana that referenced this pull request Feb 4, 2020
@azasypkin
Unify Security and EncryptedSavedObjects public contract names accord…
4873a35 
…ing to NP migration guide. (elastic#56597)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecote mikecote mikecote approved these changes

@legrego legrego legrego approved these changes

Assignees
No one assigned
Labels
backported chore Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@azasypkin @elasticmachine @kibanamachine @legrego @mikecote