Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting] New Platform Migration #56485

Closed
wants to merge 3 commits into from
Closed

[Reporting] New Platform Migration #56485

wants to merge 3 commits into from

Conversation

alexwizp
Copy link
Contributor

Part of #53898

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elastic elastic deleted a comment from kibanamachine Jan 31, 2020
@alexwizp alexwizp marked this pull request as ready for review January 31, 2020 16:15
@alexwizp alexwizp requested a review from a team as a code owner January 31, 2020 16:15
@alexwizp alexwizp added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:AppArch labels Jan 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@alexwizp alexwizp added v7.7.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jan 31, 2020
@alexwizp alexwizp self-assigned this Jan 31, 2020
@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

tsullivan
tsullivan reviewed Jan 31, 2020
View reviewed changes
x-pack/legacy/plugins/reporting/server/legacy.ts
// Schedule to call the "start" hook only after start dependencies are ready
coreSetup.getStartServices().then(([core, plugins]) =>
pluginInstance.start(core, {
data: (plugins as any).data as DataPluginStart,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be: plugins as ReportingStartDeps

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan
Copy link
Member

Hi, can you fill out the PR description and update the checklist items?

This is looking great. Thank you so much for improving our way of accessing this service!

@tsullivan tsullivan mentioned this pull request Jan 31, 2020
Merged
2 tasks
@lizozom
Copy link
Contributor

lizozom commented Feb 2, 2020

PR is relplaced by #56563

@alexwizp
Copy link
Contributor Author

alexwizp commented Feb 3, 2020

PR is relplaced by #56563

@alexwizp alexwizp closed this Feb 3, 2020
@alexwizp alexwizp deleted the reporting branch August 19, 2020 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsullivan tsullivan tsullivan left review comments

@lukeelmers lukeelmers Awaiting requested review from lukeelmers

Assignees

@alexwizp alexwizp

Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexwizp @elasticmachine @kibanamachine @tsullivan @lizozom