New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Show missing permissions message to the user on the Services overview #56374

Merged

cauemarcondes merged 5 commits into elastic:master from cauemarcondes:permission

Feb 7, 2020

Contributor

cauemarcondes commented Jan 30, 2020

closes #50052

Checks whether a user has permission to read the APM index. It does it by calling a new API /api/apm/security/permissions, it returns hasPermission: true | false. Based on this response shows the permission page on top of any APM page.

It doesn't block the UI completely, as the user can still manually close the view the open the APM page.

cauemarcondes added release_note:enhancement v7.7.0 labels

cauemarcondes requested a review from a team as a code owner

January 30, 2020 12:28

cauemarcondes commented

View reviewed changes

x-pack/legacy/plugins/apm/public/new-platform/plugin.tsx

    
                      ))}

                    </Switch>

                    {/* Check if user has permission to read from apm index. */}

                    <Permission>

Contributor Author

cauemarcondes Jan 30, 2020

The Permission component was added here, as it should show part of the original page, such as the Breadcrumbs

Contributor Author

cauemarcondes commented Jan 30, 2020

@elasticmachine merge upstream

smith requested changes

View reviewed changes

Contributor

smith left a comment

A few changes needed, but looks pretty nice.

x-pack/legacy/plugins/apm/server/lib/security/getPermissions.ts Outdated Show resolved Hide resolved

x-pack/legacy/plugins/apm/public/components/app/Permission/index.tsx Outdated Show resolved Hide resolved

x-pack/legacy/plugins/apm/public/components/app/Permission/index.tsx Outdated Show resolved Hide resolved

x-pack/legacy/plugins/apm/public/components/app/Permission/index.tsx Outdated

    
                          <EuiEmptyPrompt

                            iconType="apmApp"

                            // @ts-ignore

                            iconColor={null}

Contributor

smith Jan 31, 2020

What's with this?

Contributor Author

cauemarcondes Jan 31, 2020 •

edited

Loading

I changed it to iconColor={''} TS doesn't complain about it. But this is used to show the APM icon with color. Otherwise, it shows black and white. I will probably open a new issue because null should be valid as described here: https://elastic.github.io/eui/#/display/emptyprompt

x-pack/legacy/plugins/apm/public/components/app/Permission/index.tsx Outdated Show resolved Hide resolved

x-pack/legacy/plugins/apm/public/components/app/Permission/index.tsx Outdated Show resolved Hide resolved

x-pack/legacy/plugins/apm/public/components/app/Permission/index.tsx Outdated Show resolved Hide resolved

x-pack/legacy/plugins/apm/public/components/app/Permission/index.tsx Outdated Show resolved Hide resolved

x-pack/legacy/plugins/apm/public/components/app/Permission/index.tsx Outdated Show resolved Hide resolved

cauemarcondes requested a review from smith

January 31, 2020 09:58

Contributor Author

cauemarcondes commented Feb 3, 2020

@elasticmachine merge upstream

dgieselaar approved these changes

View reviewed changes

Member

dgieselaar left a comment

looking good, just a couple of questions & suggestions

x-pack/legacy/plugins/apm/public/components/app/Permission/index.tsx Outdated Show resolved Hide resolved

x-pack/legacy/plugins/apm/public/components/app/Permission/index.tsx Outdated Show resolved Hide resolved

x-pack/legacy/plugins/apm/public/components/shared/Links/ElasticDocsLink.tsx Show resolved Hide resolved

x-pack/legacy/plugins/apm/public/components/app/Permission/index.tsx Outdated Show resolved Hide resolved

cauemarcondes requested a review from dgieselaar

February 4, 2020 12:47

dgieselaar reviewed

View reviewed changes

x-pack/legacy/plugins/apm/public/components/app/Permission/index.tsx Outdated Show resolved Hide resolved

x-pack/legacy/plugins/apm/public/components/app/Permission/index.tsx Show resolved Hide resolved

x-pack/legacy/plugins/apm/public/components/app/Permission/index.tsx Outdated Show resolved Hide resolved

x-pack/legacy/plugins/apm/public/components/app/Permission/index.tsx Outdated Show resolved Hide resolved

x-pack/legacy/plugins/apm/public/components/app/Permission/index.tsx Outdated Show resolved Hide resolved

x-pack/legacy/plugins/apm/public/context/MatchedRouteContext.tsx Outdated Show resolved Hide resolved

x-pack/legacy/plugins/apm/public/context/MatchedRouteContext.tsx Outdated Show resolved Hide resolved

x-pack/legacy/plugins/apm/public/new-platform/plugin.tsx Outdated Show resolved Hide resolved

x-pack/legacy/plugins/apm/public/components/app/Main/ProvideBreadcrumbs.tsx Outdated Show resolved Hide resolved

x-pack/legacy/plugins/apm/public/components/app/Permission/index.tsx Outdated Show resolved Hide resolved

cauemarcondes force-pushed the permission branch from 1915b15 to 881cd57 Compare

February 5, 2020 11:09

cauemarcondes requested a review from dgieselaar

February 5, 2020 11:11

smith approved these changes

View reviewed changes

dgieselaar reviewed

View reviewed changes

x-pack/legacy/plugins/apm/public/context/MatchedRouteContext.tsx Outdated Show resolved Hide resolved

cauemarcondes added 5 commits

February 6, 2020 15:43


          creating permission page

f4dc9dc


          pr comments

d16a813


          creating permission page

22b03ee


          fixing pr comments

e680a83


          removing breadcrumb and adding static label to dismiss the permission…

ac6ab86

… page

cauemarcondes force-pushed the permission branch from 881cd57 to ac6ab86 Compare

February 6, 2020 15:05

Contributor

kibanamachine commented Feb 6, 2020

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ac6ab86

History

💚 Build #24542 succeeded 881cd57aad7bdb831864ebc65ef556f034d0604d
💚 Build #24293 succeeded bf2ea13bb344815b0c5e08140f34424bed1f913e
💚 Build #23937 succeeded 7f4fc6d7e0fdd0eeb943c45ac15a405cf7e41baa
💛 Build #23686 was flaky b1bbecc01b31132161e919abfb9b3447e5cbb9ff
💛 Build #23499 was flaky e3bfcfd163eb4e76a328d15ba86a6406b1da45d7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cauemarcondes merged commit 07cb4c1 into elastic:master

cauemarcondes deleted the permission branch

February 7, 2020 08:02

cauemarcondes mentioned this pull request

[7.x] [APM] Show missing permissions message to the user on the Services overview (#56374) #57082

Merged

cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request


          [APM] Show missing permissions message to the user on the Services ov…

56ef098

…erview (elastic#56374)

* creating permission page

* pr comments

* creating permission page

* fixing pr comments

* removing breadcrumb and adding static label to dismiss the permission page

cauemarcondes added a commit that referenced this pull request


          [APM] Show missing permissions message to the user on the Services ov…

fa8becb

…erview (#56374) (#57082)

* creating permission page

* pr comments

* creating permission page

* fixing pr comments

* removing breadcrumb and adding static label to dismiss the permission page

jloleysens added a commit to jloleysens/kibana that referenced this pull request


          Merge branch 'console/feature/text-objects-in-saved-objects' of githu…

9e266c6

…b.com:jloleysens/kibana into console/feature/text-objects-in-saved-objects

* 'console/feature/text-objects-in-saved-objects' of github.com:jloleysens/kibana: (103 commits)
  fix auto closing new vis modal when navigating to lens or when navigating away with browser history (elastic#56998)
  TS of esKuery\node_types  (elastic#56857)
  Kibana app migration: Move static code dependencies into kibana_legacy plugin, part 1 (elastic#56408)
  Retry ES API calls that fail with 410/Gone (elastic#56950)
  [APM] Show missing permissions message to the user on the Services overview (elastic#56374)
  Fixing flaky CI tests for custom appRoutes (elastic#55763)
  [State Management][Docs] State syncing utils docs (elastic#56479)
  [Index management] Remove index mapper setting in tests (elastic#57066)
  Exposed common EuiExpressions to separate components be able to reuse for building new for Alert Types  (elastic#56466)
  [SIEM] update url state between page if date is relative (elastic#56813)
  fix for chart_types test (elastic#57056)
  chore(NA): remove compress from dll minimizer (elastic#57023)
  [File upload] Migrate routing to NP & add route validation (elastic#52313)
  Adding docs for grouped nav advanced setting (elastic#57013)
  Use i18n titles for field formatters, human names for numeral locales (elastic#56348)
  [Maps] Remove EMS catalogue url from docs (elastic#57020)
  [Endpoint] ERT-82 ERT-83 ERT-84: Alert list API with pagination (elastic#56538)
  [DOCS] Adds Apple notarization info to install doc (elastic#57042)
  [ML] New Platform server shim: update results service routes to use new platform router (elastic#56886)
  Fix typo on detection engine rule (elastic#56993)
  ...

cauemarcondes mentioned this pull request

[APM] Use ES Privileges API to check if a user has permissions to read from APM indices #57215

Closed

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:enhancement v7.7.0