[Canvas] Migrate Shareable Routes to NP #56053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqliu1
force-pushed
the
np/shareables-routes
branch
from
6252980 to
f7bce6c
Compare
cqliu1
added
review
Team:Presentation
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
cqliu1
added
loe:medium
cqliu1
force-pushed
the
np/shareables-routes
branch
from
f7bce6c to
c3b16e3
Compare
poffdeluxe
approved these changes
Jan 30, 2020
| import { functions } from '../canvas_plugin_src/functions/server'; | ||
| import { loadSampleData } from './sample_data'; | ||
|
|
||
| export class Plugin { | ||
| public setup(core: CoreSetup, plugins: PluginsSetup) { | ||
| routes(core); |
| router.get( | ||
| { | ||
| path: API_ROUTE_SHAREABLE_RUNTIME_DOWNLOAD, | ||
| validate: false, |
There was a problem hiding this comment.
why no validation on this route?
There was a problem hiding this comment.
It's not required for this route. We don't expected anything to be passed in as part of the request.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
cqliu1
added a commit
that referenced
this pull request
Feb 1, 2020
jfsiii
pushed a commit
to jfsiii/kibana
that referenced
this pull request
Feb 4, 2020
* Migrated shareables routes to NP * Added tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds tests for and migrates the remaining legacy routes used for Canvas Shareables to NP.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers