Vis default editor plugin #55612

sulemanof · 2020-01-22T21:09:06Z

Summary

Resolves #55287.

This PR create the vis_default_editor plugin.
It provides the main component DefaultEditorController for consuming in visualizations plugin and accepts necessary kibana services, then shares it through the KibanaContextProvider.

The PR contains the next changes:

removed all of the links to ui/vis through the kibana;
moved schemas.ts to the agg_types;
created the agg_params_map.ts to specify components for an aggregation and exclude dependencies in agg_types on vis_default_editor;
created the namespace visDefaultEditor for translations;

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

…editor # Conflicts: # src/legacy/ui/public/vis/_index.scss

…editor

sulemanof · 2020-01-24T16:10:10Z

src/legacy/core_plugins/vis_default_editor/public/_sidebar.scss

@@ -59,15 +59,6 @@
  + .visEditorSidebar__section {
    margin-top: $euiSizeS;
  }
-
-  label:not([class^='eui']) {
-    @include __legacyLabelStyles__bad;


This is removed due to no necessity anymore. All the label were removed during EUIfication

…editor # Conflicts: # src/legacy/core_plugins/kibana/public/discover/np_ready/angular/discover.js # src/legacy/core_plugins/vis_default_editor/public/default_editor.tsx

sulemanof · 2020-01-27T08:58:25Z

.eslintrc.js

@@ -88,6 +88,14 @@ module.exports = {
        'react-hooks/exhaustive-deps': 'off',
      },
    },
+    {
+      files: [
+        'src/legacy/core_plugins/vis_default_editor/public/components/controls/**/*.{ts,tsx}',


All of the controls ignored as a temporary solution, I'll create an additional task to update it and exclude any possible regression and circular re-renders.

…editor # Conflicts: # src/legacy/core_plugins/visualizations/public/embeddable/query_geohash_bounds.ts # src/legacy/core_plugins/visualizations/public/saved_visualizations/_saved_vis.ts # src/legacy/ui/public/agg_types/agg_config.ts # src/legacy/ui/public/agg_types/agg_configs.ts # src/legacy/ui/public/agg_types/param_types/base.ts # src/legacy/ui/public/visualize/loader/pipeline_helpers/utilities.ts # src/legacy/utils/index.d.ts

sulemanof · 2020-01-28T07:34:54Z

Hey @ppisljar @flash1293
The last thing which is not fully clear for me is, should I move schemas.ts back to the default editor and import this in agg_types ?
Since one of the main goals of this PR was to remove all the references in agg_types to default editor, I'm a bit about confused about those.

ppisljar · 2020-01-28T11:59:15Z

moving of schemas back: if it doesn't cause any headaches please do, but i think its not a blocker for this pr, we can move it later.

ryankeairns

SCSS files look good. Several relocated, one removed along with its related import reference.

…editor # Conflicts: # src/legacy/core_plugins/region_map/public/region_map_type.js # src/legacy/core_plugins/tile_map/public/tile_map_type.js # src/legacy/core_plugins/vis_type_metric/public/components/metric_vis_component.test.tsx # src/legacy/core_plugins/vis_type_metric/public/components/metric_vis_component.tsx # src/legacy/core_plugins/vis_type_metric/public/legacy_imports.ts # src/legacy/core_plugins/vis_type_metric/public/metric_vis_type.ts # src/legacy/core_plugins/vis_type_vislib/public/components/common/color_schema.tsx # src/legacy/core_plugins/vis_type_vislib/public/gauge.ts # src/legacy/core_plugins/vis_type_vislib/public/goal.ts # src/legacy/core_plugins/vis_type_vislib/public/heatmap.ts # src/legacy/core_plugins/vis_type_vislib/public/legacy_imports.ts # x-pack/legacy/plugins/maps/public/layers/joins/inner_join.test.js # x-pack/legacy/plugins/maps/public/layers/sources/es_term_source.test.js # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json

nreese

maps changes LGTM

kibanamachine · 2020-01-29T14:17:08Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b5b295a

History

💔 Build #23249 failed 29b3250
💚 Build #22963 succeeded d90f93c
💔 Build #22928 failed 4fc4d8f
💔 Build #22635 failed 398b0dd
💔 Build #22605 failed e5ccc76

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

flash1293

LGTM, good work!

ppisljar

code LGTM. Thanks, this will unblock some things for us!

* Vis default editor plugin (#55612) * Shim the default_editor * Update paths in vis_default_editor * Update paths in dependent plugins * Update the dependent plugins * Create an entry point * Wrap the editor with kibana context * Fix circular re-renders * Update sub aggs mapping * Move schemas and agg_groups to agg_types, update jest tests * Use services from kibana context, other fixes * Fix useEffect maximum update depth * Create i18n namesapce for visDefaultEditor, rename translations * Fix tests * Resolve paths * Remove ui/vis/vis_types * Fix vis import * Move editor_config_provider to ui/vis * Remove agg_select.html

sulemanof added 11 commits January 21, 2020 14:00

Shim the default_editor

b60d4d4

Update paths in vis_default_editor

9db3b3a

Merge remote-tracking branch 'upstream/master' into shim/vis_default_…

c30c349

…editor # Conflicts: # src/legacy/ui/public/vis/_index.scss

Update paths in dependent plugins

18d0309

Update the dependent plugins

d405cd2

Create an entry point

a79b235

Merge remote-tracking branch 'upstream/master' into shim/vis_default_…

98d9bb1

…editor

Wrap the editor with kibana context

6f5c3b3

Fix circular re-renders

695ef0a

Update sub aggs mapping

fb0fe0d

Move schemas and agg_groups to agg_types, update jest tests

399e868

sulemanof commented Jan 24, 2020

View reviewed changes

sulemanof added 6 commits January 25, 2020 13:44

Use services from kibana context, other fixes

d8446e9

Fix useEffect maximum update depth

8edd511

Create i18n namesapce for visDefaultEditor, rename translations

e5ccc76

Fix tests

255310d

Merge remote-tracking branch 'upstream/master' into shim/vis_default_…

8acf4c4

…editor # Conflicts: # src/legacy/core_plugins/kibana/public/discover/np_ready/angular/discover.js # src/legacy/core_plugins/vis_default_editor/public/default_editor.tsx

Resolve paths

398b0dd

sulemanof requested review from ppisljar and flash1293 January 27, 2020 08:56

sulemanof commented Jan 27, 2020

View reviewed changes

sulemanof marked this pull request as ready for review January 27, 2020 09:30

sulemanof requested a review from a team January 27, 2020 09:30

sulemanof requested review from a team as code owners January 27, 2020 09:30

sulemanof added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0 labels Jan 27, 2020

Remove ui/vis/vis_types

4fc4d8f

Fix vis import

d90f93c

sulemanof mentioned this pull request Jan 28, 2020

Improve Top Hit aggregation "field" names #54460

Closed

ryankeairns approved these changes Jan 28, 2020

View reviewed changes

nreese approved these changes Jan 29, 2020

View reviewed changes

Move editor_config_provider to ui/vis

b5b295a

flash1293 approved these changes Jan 29, 2020

View reviewed changes

ppisljar approved these changes Jan 29, 2020

View reviewed changes

sulemanof merged commit 7f63118 into master Jan 29, 2020

sulemanof deleted the shim/vis_default_editor branch January 29, 2020 14:41

sulemanof mentioned this pull request Jan 29, 2020

[7.x] Vis default editor plugin (#55612) #56297

Merged

sulemanof added the backported label Jan 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vis default editor plugin #55612

Vis default editor plugin #55612

sulemanof commented Jan 22, 2020 •

edited

Loading

sulemanof Jan 24, 2020

sulemanof Jan 27, 2020

sulemanof commented Jan 28, 2020

ppisljar commented Jan 28, 2020

ryankeairns left a comment

nreese left a comment

kibanamachine commented Jan 29, 2020

flash1293 left a comment

ppisljar left a comment

Vis default editor plugin #55612

Vis default editor plugin #55612

Conversation

sulemanof commented Jan 22, 2020 • edited Loading

Summary

Checklist

For maintainers

sulemanof Jan 24, 2020

Choose a reason for hiding this comment

sulemanof Jan 27, 2020

Choose a reason for hiding this comment

sulemanof commented Jan 28, 2020

ppisljar commented Jan 28, 2020

ryankeairns left a comment

Choose a reason for hiding this comment

nreese left a comment

Choose a reason for hiding this comment

kibanamachine commented Jan 29, 2020

💚 Build Succeeded

History

flash1293 left a comment

Choose a reason for hiding this comment

ppisljar left a comment

Choose a reason for hiding this comment

sulemanof commented Jan 22, 2020 •

edited

Loading