📕 Storybook 3

[streamich]

Summary

• Upgrades Storybook to 5.3.x.
• Switches to @kbn/ui-shared-deps instead of custom DLL.
• Adds a sample story to embeddable plugin that uses Storybook knobs.
• Partially addresses 📕 Storybook Roadmap #54707

[elasticmachine]

Pinging @elastic/kibana-operations (Team:Operations)

[elasticmachine]

Pinging @elastic/kibana-app-arch (Team:AppArch)

[kibanamachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request
• Commit: af64da5

History

• 💔 Build #21216 failed e0b5539

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[smith]

Running yarn storybook apm with this gives me a very long output of errors that looks like:

.js
              Field 'browser' doesn't contain a valid alias configuration
              /Users/smith/Code/kibana/node_modules/react-syntax-highlighter/prism-light.js doesn't exist

over and over for every location it's trying.

The actual file it's looking for is in node_modules/react-syntax-highlighter/dist/cjs/prism-light.js or node_modules/react-syntax-highlighter/dist/esm/prism-light.js.

The package.json for that module (which is a direct dependency in x-pack's package.json and used by APM) looks normal and defines main and module keys for the index.js files in those respective cjs and esm directories.

I couldn't think of what to do to the kbn-storybook webpack config to fix this and googling wasn't helpful for me.

Please try it and make sure it happens for you too. I did a yarn kbn bootstrap before trying.