[ML] Fix decoding in the URL state #54915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
:ml
v8.0.0
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
| if (decodedParams.has(a)) { | ||
| urlState[a] = decode(parsedQueryString[a]) as Dictionary<any>; | ||
| } else { | ||
| urlState[a] = parsedQueryString[a]; |
There was a problem hiding this comment.
i don't know if items which aren't _a or _g are needed at all for the url state.
but it might also do no harm collecting them. @walterra would need to confirm
There was a problem hiding this comment.
At the moment also setting the urlState expects all of url state so I suggest to keep it like that for now. I did it this way because useLocation is not mutable and I always needed the full most recent value for getting/setting search.
@darnautov Thanks for adding the test! Seems you forgot to commit to export getUrlState so the test fails on CI at the moment. Can you also add a test to check the other way around when setting the url state? I suspect we also need a check against decodedParams when setting the state here.
x-pack/legacy/plugins/ml/public/application/util/url_state.test.ts
Outdated
Show resolved
Hide resolved
darnautov
force-pushed
the
ML-54885-fix-url-state-decode
branch
from
2418175 to
40d9646
Compare
peteharverson
approved these changes
Jan 16, 2020
walterra
approved these changes
Jan 16, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Jan 17, 2020
* [ML] condition for rison decode in getUrlState * [ML] fix icon alignment * [ML] use Set * [ML] add export, fix typo * [ML] setUrlState test * [ML] fields stats width
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Jan 17, 2020
* [ML] condition for rison decode in getUrlState * [ML] fix icon alignment * [ML] use Set * [ML] add export, fix typo * [ML] setUrlState test * [ML] fields stats width
darnautov
added a commit
that referenced
this pull request
Jan 17, 2020
darnautov
added a commit
that referenced
this pull request
Jan 17, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 17, 2020
…t-of-legacy * 'master' of github.com:elastic/kibana: (142 commits) [Vis] Move Timelion Vis to vis_type_timelion (elastic#52069) Deprecate `chrome.navlinks.update` and add documentation (elastic#54893) [ML] Single Metric Viewer: Fix time bounds with custom strings. (elastic#55045) [Vis: Default editor] EUIficate and Reactify the sidebar (elastic#49864) [Mappings editor] Fix cannot set boolean value for "null_value" param (elastic#55015) [SIEM] Adds support for apm-* to the network map (elastic#54876) [Reporting] Define shims of legacy dependencies (elastic#54082) Resolver is overflow: hidden to prevent obscured elements from showing up (elastic#55076) Upgraded EUI to 18.2.1 (elastic#55090) [Maps] Support styles on agg fields with _of_ in name (elastic#54965) Remove xpack_main requirement, it's no longer in use (elastic#55060) Fix Snapshots Policies Alignment Issue in IE11 (elastic#54866) first rule cuts (elastic#54990) [DOCS] Adds geocentroid note to coordinate map (elastic#54389) [Canvas] Fixes the Copy Post Url link (elastic#54831) Fixes bugs with full screen filters (elastic#54792) [ML] Fix decoding in the URL state (elastic#54915) Remove redundant `x-pack/typings`. (elastic#55042) [SIEM][Detection Engine] Adds critical missing status route to prepackaged rules Generate legacy vars when rendering all applications (elastic#54768) ... # Conflicts: # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
* [ML] condition for rison decode in getUrlState * [ML] fix icon alignment * [ML] use Set * [ML] add export, fix typo * [ML] setUrlState test * [ML] fields stats width
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #54885. Use rison decoding only for
_aand_gquery parameters.Besides contains some fixes for minor issues on Data Visualiser page.
Checklist
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibility