[Mappings editor] Fix clear searchbox #54880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebelga
added
bug
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
sebelga
added
the
release_note:skip
💚 Build SucceededTo update your PR or re-run it, just comment with: |
alisonelizabeth
approved these changes
Jan 15, 2020
sebelga
added a commit
to sebelga/kibana
that referenced
this pull request
Jan 16, 2020
sebelga
added a commit
that referenced
this pull request
Jan 16, 2020
sebelga
added a commit
that referenced
this pull request
Jan 16, 2020
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression bug when clearing the search box that was introduced with the update to eui
v18.0.0(6bed80b#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R121)I left a comment in EUI https://github.com/elastic/eui/pull/2723/files#r366725059
It makes me wonder if bumping a major version of EUI the day of FF is a good idea 😊
Fix #54810