Move rendering functional tests and add user settings tests #54801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliperelman
added
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
💔 Build FailedTo update your PR or re-run it, just comment with: |
joshdover
reviewed
Jan 14, 2020
|
|
||
| describe('rendering', () => { | ||
| it('renders "core" application', async () => { | ||
| await supertest.get('/render/core').expect(200, /app:core/); |
There was a problem hiding this comment.
Isn't this API only available in the plugin functional tests where the rendering plugin is available?
|
Superseded by #54768. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move rendering functional tests to
plugin_functionaland add rendering tests for user settings variations. Follow-up enhancement from initial rendering service.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately