[Logs UI] Disable ML job setup form while setup is pending #54705
Conversation
weltenwort
added
release_note:enhancement
v8.0.0
Feature:Logs UI
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
| setValidatedIndices, | ||
| validationErrors = [], | ||
| }: InitialConfigurationStepProps) => { | ||
| const disabled = useMemo(() => !editableFormStatus.includes(setupStatus), [setupStatus]); |
There was a problem hiding this comment.
What's changing this setupStatus value and where?
There was a problem hiding this comment.
It's being passed in as a property to the component. It originates from the job management hook that uses a combination of the ML API responses and the setup flow state to determine the overall setup state.
There was a problem hiding this comment.
More precisely, this is the file with the reducer that derives the setupState: https://github.com/weltenwort/kibana/blob/d7bc217827d19aced14fe3f47b83a85567a41b96/x-pack/legacy/plugins/infra/public/containers/logs/log_analysis/log_analysis_module_status.tsx
There was a problem hiding this comment.
Ah ok so this value was already being set, gotcha. Looks good then!
weltenwort
deleted the
logs-ui-ml-integration-disable-setup-form-when-pending
branch
…4705) This disables the configuration for in the log rate and categories setup screens while the setup process is ongoing.
Backports the following commits to 7.x: - [Logs UI] Disable ML job setup form while setup is pending (#54705)
…4705) This disables the configuration for in the log rate and categories setup screens while the setup process is ongoing.
Summary
This PR disables the configuration for in the log rate and categories setup screens while the setup process is ongoing.
closes #54555
Previews
Checklist
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibility