Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Add expandable rows with category examples #54586

Merged
merged 29 commits into from
Mar 11, 2020
Merged

[Logs UI] Add expandable rows with category examples #54586

merged 29 commits into from
Mar 11, 2020

Conversation

weltenwort
Copy link
Member

@weltenwort weltenwort commented Jan 13, 2020 •
edited
Loading

Summary

This makes the category rows expandable to show actual examples of log messages from the categories during the selected time frame.

closes #50456

Preview

With expanded examples and loading indicator
grafik

When fetching log entry samples failed
grafik

When underlying log entry samples are not available anymore
grafik

TODO

  • load and render examples
  • show loading indicator
  • show error message with retry (if fetching failed)
  • align columns
  • show empty message with retry (if fetching resulted in zero examples)
  • add "Analyze in ML" links for each category and dataset

@weltenwort weltenwort added v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.7.0 labels Jan 13, 2020
@weltenwort weltenwort self-assigned this Jan 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

pheyos
pheyos reviewed Jan 15, 2020
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing the GH review comment functionality...
Works.

@pheyos pheyos requested review from pheyos and removed request for pheyos January 15, 2020 09:20
@weltenwort weltenwort force-pushed the logs-ui-categorization-add-examples branch from fce8a3b to 59b37bc Compare February 3, 2020 15:16
@weltenwort
Use transport.request fallback to query ml jobs
7d58cd2
@weltenwort
Prepare log rows and columns for re-use
fc75abf
@weltenwort
Render example message using log stream components
a751fd9
@weltenwort
Introduce a stricter wrapping mode for the examples
ba2b552
@weltenwort
Add example loading indicators
551df33
@weltenwort
Add example loading failure message with retry option
2645faf
@weltenwort
Remove mismatching log message background color
eaceb39
@weltenwort
Merge branch 'master' into logs-ui-categorization-add-examples
687bdfb
@weltenwort
Add dataset column to examples and align columns
75e4f4c
@weltenwort
Merge branch 'master' into logs-ui-categorization-add-examples
e82cc54
@weltenwort
Merge branch 'master' into logs-ui-categorization-add-examples
b668695
@weltenwort
Remove unused translations via autofix
704e123
@weltenwort
Merge branch 'master' into logs-ui-categorization-add-examples
3074c48
@weltenwort
Merge branch 'master' into logs-ui-categorization-add-examples
40bbbac
@weltenwort
Display per-dataset anomaly scores and ML links
422dfea
@weltenwort
Adjust dataset column width in example rows
182098d
@weltenwort
Add message for empty example response
55db708
@weltenwort
Merge branch 'master' into logs-ui-categorization-add-examples
ff6521e
@weltenwort weltenwort requested a review from a team as a code owner March 3, 2020 15:58
@weltenwort
Copy link
Member Author

@elasticmachine merge upstream

@weltenwort
Copy link
Member Author

@elasticmachine merge upstream

@Kerry350 Kerry350 self-requested a review March 9, 2020 10:38
Kerry350
Kerry350 approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 👍 Couple of minor comments.

Not directly linked to this PR, but there seems to be some problems creating the ML jobs against our shared Observability cluster (on any space).

Screenshot 2020-03-10 11 09 52

I got things working against a local setup though.

One final thing, is it expected to have so many unknowns under the dataset column?

Screenshot 2020-03-10 13 47 46

...lic/pages/logs/log_entry_categories/sections/top_categories/analyze_dataset_in_ml_action.tsx Outdated Show resolved Hide resolved
x-pack/plugins/infra/public/components/logging/log_text_stream/text_styles.tsx Outdated Show resolved Hide resolved
@weltenwort
Copy link
Member Author

Thanks a lot for the review!

there seems to be some problems creating the ML jobs against our shared Observability cluster

Looks like the Elasticsearch version on our dev cluster is not compatible with recent changes of the ML module API.

is it expected to have so many unknowns under the dataset column

Seeing that the category itself has a dataset, this doesn't look right. I'll look into it.

@weltenwort
Copy link
Member Author

weltenwort commented Mar 11, 2020 •
edited
Loading

is it expected to have so many unknowns under the dataset column

image

@Kerry350, I indeed made a mistake reading the value from _source. Thanks for catching that!

I fixed it and migrated to the new link hook in case you want to take another look.

@Kerry350
Copy link
Contributor

@weltenwort All the latest changes look good. Thanks for entertaining the original renaming 👍

Yay 😄

Screenshot 2020-03-11 12 00 46

@weltenwort
Copy link
Member Author

@elasticmachine merge upstream

@weltenwort
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@weltenwort weltenwort merged commit 07a7caa into elastic:master Mar 11, 2020
@weltenwort weltenwort deleted the logs-ui-categorization-add-examples branch March 11, 2020 19:07
@weltenwort weltenwort mentioned this pull request Mar 11, 2020
Merged
weltenwort added a commit to weltenwort/kibana that referenced this pull request Mar 11, 2020
@weltenwort
[Logs UI] Add expandable rows with category examples (elastic#54586)
3ddb920 
Make the category rows expandable to show actual log messages samples from the categories during the selected time frame.
weltenwort added a commit that referenced this pull request Mar 11, 2020
@weltenwort
[7.x] [Logs UI] Add expandable rows with category examples (#5… (#59945)
b438a53 
Backports the following commits to 7.x:
 - [Logs UI] Add expandable rows with category examples (#54586)
@weltenwort weltenwort mentioned this pull request Mar 13, 2020
Merged
weltenwort added a commit that referenced this pull request Mar 16, 2020
@weltenwort
[Logs UI] Fix log rate table row expansion (#60096)
6cd888f 
This fixes the log rate table row expansion button, which broke in #54586 during a refactoring.
weltenwort added a commit to weltenwort/kibana that referenced this pull request Mar 16, 2020
@weltenwort
[Logs UI] Fix log rate table row expansion (elastic#60096)
ad06c81 
This fixes the log rate table row expansion button, which broke in elastic#54586 during a refactoring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pheyos pheyos pheyos left review comments

@Kerry350 Kerry350 Kerry350 approved these changes

Assignees

@weltenwort weltenwort

Labels
Feature:Logs UI Logs UI feature release_note:enhancement Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Logs UI] Add expandable rows to show example logs for categories
5 participants
@weltenwort @elasticmachine @Kerry350 @kibanamachine @pheyos