[Data Plugin] combine autocomplete provider and suggestions provider #54451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # x-pack/legacy/plugins/uptime/public/pages/overview.tsx
…- add skeleton for SuggestionsProvider
# Conflicts: # x-pack/legacy/plugins/uptime/public/pages/overview.tsx
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
alvarezmelissa87
approved these changes
Jan 16, 2020
Bargs
suggested changes
Jan 16, 2020
There was a problem hiding this comment.
Functionality looks good. Looking at the code, I focused just on the service itself since others have looked at the app usages and the NP stuff. I like how you've pulled all these separate pieces together, it makes the autocomplete picture easier to understand.
The only thing I would suggest is changing the name of getFieldSuggestions. To me, this name implies it will suggest field names, but in actuality is suggests values. That's especially confusing since we have another function called getFieldSuggestions which actually does provide field names. I would prefer getValueSuggestions.
|
@Bargs |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Bargs
approved these changes
Jan 17, 2020
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Jan 17, 2020
…lastic#54451) * [Data Plugin] combine autocomplete provider and suggestions provider Closes: elastic#52843 * [Data Plugin] combine autocomplete provider and suggestions provider - add skeleton for SuggestionsProvider * autocomplete_provider -> autocomplete * value_suggestions.ts - change getSuggestions method * remove suggestions_provider folder * fix PR comments * fix PR comments * fix CI * fix CI * getFieldSuggestions -> getValueSuggestions * update Jest snaphots Co-authored-by: Elastic Machine <[email protected]>
alexwizp
added a commit
that referenced
this pull request
Jan 18, 2020
…54451) (#55224) * [Data Plugin] combine autocomplete provider and suggestions provider Closes: #52843 * [Data Plugin] combine autocomplete provider and suggestions provider - add skeleton for SuggestionsProvider * autocomplete_provider -> autocomplete * value_suggestions.ts - change getSuggestions method * remove suggestions_provider folder * fix PR comments * fix PR comments * fix CI * fix CI * getFieldSuggestions -> getValueSuggestions * update Jest snaphots Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 20, 2020
* upstream/master: (83 commits) [Reporting] Fix map tiles not loading by using Chrome's Remote Protocol (elastic#55137) [Data Plugin] combine autocomplete provider and suggestions provider (elastic#54451) resolves elastic#53038 - remove references to specific license levels (elastic#53858) highlighting rules should still know about url parts when in sql state (elastic#55200) [Metric] convert mocha tests to jest (elastic#54054) [skip-ci] Update vector styling docs for 7.6 UI changes and new features (elastic#55087) Fix enable API to schedule task after alert is updated (elastic#55095) chore(NA): add 7.6 branch to the list of backport branches (elastic#54998) Convert tests to jest in vis_type_timeseries/public & common folders (elastic#55023) [ML] Accessibility fix for structural markup on table rows (elastic#55075) [Mappings editor] include/exclude fields only support custom options (elastic#54949) [Vis] Move Timelion Vis to vis_type_timelion (elastic#52069) Deprecate `chrome.navlinks.update` and add documentation (elastic#54893) [ML] Single Metric Viewer: Fix time bounds with custom strings. (elastic#55045) [Vis: Default editor] EUIficate and Reactify the sidebar (elastic#49864) [Mappings editor] Fix cannot set boolean value for "null_value" param (elastic#55015) [SIEM] Adds support for apm-* to the network map (elastic#54876) [Reporting] Define shims of legacy dependencies (elastic#54082) Resolver is overflow: hidden to prevent obscured elements from showing up (elastic#55076) Upgraded EUI to 18.2.1 (elastic#55090) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #52843
Summary
Currently in
src/plugins/data/publicwe have anautocomplete_providerandsuggestions_provider.autocompleteis exposed in the setup contract under data.autocompletesuggestionsare exposed in the start contract under getSuggestionsSince these are both thematically related, I we should merge them together into a single autocomplete service in the
data pluginChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers