Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Management advanced settings telemetry #54369

Merged

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Jan 9, 2020

Summary

Report UI Settings, which differ from their default values in telemetry, in order to be able to track setting usage.

For Kibanas with multiple spaces defined, the settings reported in telemetry are of the default space only.

Also tested fields appear in actual telemetry report:
image

In order to use this data in our telemetry dashboards, we need to map interesting advanced settings to fields.

@AlonaNadler FYI this will be available in v7.6

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@lizozom lizozom force-pushed the newplatform/data/search-msearch-telemetry branch from be11f7b to 3926d78 Compare January 9, 2020 17:00
@lizozom lizozom self-assigned this Jan 12, 2020
@lizozom lizozom requested a review from Bamieh January 12, 2020 13:41
@lizozom lizozom added Feature:New Platform Feature:Search Querying infrastructure in Kibana Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes Team:AppArch v7.6.0 v8.0.0 labels Jan 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lizozom lizozom force-pushed the newplatform/data/search-msearch-telemetry branch from 38fc790 to fdaaba9 Compare January 12, 2020 13:45
@lizozom lizozom marked this pull request as ready for review January 12, 2020 13:46
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

  • 💔 Build #19052 failed 3926d78beb76ae1693a8926b7ba919db64257e04

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've also pulled the code and checked the usage data on the default space:

With custom settings:
image

No user specific changes:
image

I did not test this across spaces.

@lizozom lizozom merged commit ebd2c21 into elastic:master Jan 13, 2020
lizozom pushed a commit to lizozom/kibana that referenced this pull request Jan 13, 2020
* management telemetry

* Use getUserProvided
lizozom pushed a commit that referenced this pull request Jan 13, 2020
* management telemetry

* Use getUserProvided
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
* management telemetry

* Use getUserProvided
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Platform Feature:Search Querying infrastructure in Kibana Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants