Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitoring] Ensure setup mode work in a ccs environment #54361

Merged
merged 2 commits into from
Jan 9, 2020
Merged

[Monitoring] Ensure setup mode work in a ccs environment #54361

merged 2 commits into from
Jan 9, 2020

Conversation

chrisronline
Copy link
Contributor

Fixes #54354

See the issue for testing steps.

Also, added a rudimentary test for each endpoint. Ideally, we have better CCS-based tests but that's a larger-term project.

@chrisronline chrisronline requested a review from igoristic January 9, 2020 16:03
@chrisronline chrisronline self-assigned this Jan 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

igoristic
igoristic approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✅ Nice catch 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline chrisronline merged commit dfac5d8 into elastic:master Jan 9, 2020
@chrisronline chrisronline deleted the monitoring/setup_mode_ccs branch January 9, 2020 18:14
@chrisronline chrisronline mentioned this pull request Jan 9, 2020
Merged
chrisronline added a commit to chrisronline/kibana that referenced this pull request Jan 9, 2020
@chrisronline
[Monitoring] Ensure setup mode work in a ccs environment (elastic#54361)
1d03b96 
* Ensure setup mode work in a ccs environment

* Missed this file
@chrisronline chrisronline mentioned this pull request Jan 9, 2020
Merged
chrisronline added a commit to chrisronline/kibana that referenced this pull request Jan 9, 2020
@chrisronline
[Monitoring] Ensure setup mode work in a ccs environment (elastic#54361)
1d70813 
* Ensure setup mode work in a ccs environment

* Missed this file
chrisronline added a commit that referenced this pull request Jan 9, 2020
@chrisronline
[Monitoring] Ensure setup mode work in a ccs environment (#54361) (#5…
195508d 
…4381)

* Ensure setup mode work in a ccs environment

* Missed this file
@chrisronline
Copy link
Contributor Author

chrisronline commented Jan 9, 2020 •
edited
Loading

Backport:

7.x: ace1893
7.5: 195508d

chrisronline added a commit that referenced this pull request Jan 9, 2020
@chrisronline
[Monitoring] Ensure setup mode work in a ccs environment (#54361) (#5…
ace1893 
…4380)

* Ensure setup mode work in a ccs environment

* Missed this file
dgieselaar pushed a commit to ogupte/kibana that referenced this pull request Jan 10, 2020
@chrisronline @dgieselaar
[Monitoring] Ensure setup mode work in a ccs environment (elastic#54361)
d4d98a7 
* Ensure setup mode work in a ccs environment

* Missed this file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igoristic igoristic igoristic approved these changes

Assignees

@chrisronline chrisronline

Labels
release_note:fix review Team:Monitoring Stack Monitoring team v7.5.2 v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Monitoring] Setup mode doesn't work in a CCS environment
4 participants
@chrisronline @elasticmachine @kibanamachine @igoristic