[Canvas] Change Markdown element title to Text #54194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryankeairns
added
impact:medium
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
ryankeairns
force-pushed
the
rk/28992-markdown-text
branch
from
2de0545 to
c9a0c04
Compare
ryankeairns
changed the title
ryankeairns
added
review
impact:low
💚 Build SucceededTo update your PR or re-run it, just comment with: |
ryankeairns
added a commit
to ryankeairns/kibana
that referenced
this pull request
Jan 7, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 8, 2020
* master: (55 commits) [ui/public/utils] Copy rarely used items to where they are consumed (elastic#53819) set AppArch team as an owner of the search endpoints (elastic#54131) Don't expose Elasticsearch client as Observable (elastic#53824) [SIEM] Cleanup unnecessary use of enzyme-to-json (elastic#53980) fix ui exports doc (elastic#54138) change markdown element title (elastic#54194) [Logs UI] Refactor log position to hooks (elastic#53540) [SIEM] Implement NP Plugin Setup (elastic#54030) [DOCS] Updates ML links (elastic#53613) sort renovate packages in config Spaces - fix flakey api tests (elastic#54154) Remove dependency that was causing effect to re-execute infinitely. (elastic#54160) [dev/run] expose unexpected flags as more than just names (elastic#54080) [DOCS] Moves index pattern doc to Discover (elastic#53347) [SIEM] Cleanup React imports (elastic#53981) Update eslint related packages (elastic#54107) [Uptime] Added date range filter into expanded list query (elastic#52609) [SIEM] Add react/display-name eslint rule (elastic#53107) [SIEM] Enable eslint prefer-template rule (elastic#53983) Elasticsearch snapshots automation (elastic#53706) ...
ryankeairns
added a commit
that referenced
this pull request
Jan 8, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28992
Summary
A common task is adding text to your workpad. Through testing and anecdotal feedback, we've learned that users often look for the word 'Text' when trying to complete this task. Currently, the only way to add text is by adding the Markdown element to your page, but Markdown is not nearly as ubiquitous a term as Text.
Notes
This PR is a short-term, low-hanging fruit, solution that re-titles the Markdown element. In the future, we may add a plain text element and/or allow users to select a text tool/button and click into the page.
You may also notice that some element card titles are center-aligned. I have opened a PR in the EUI repo to fix this: elastic/eui#2741
Screenshot
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers