-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIEM] [Case] Service Now Kibana Action #53890
[SIEM] [Case] Service Now Kibana Action #53890
Conversation
Pinging @elastic/siem (Team:SIEM) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
I noted that since the url to ServiceNow is configurable, a FTS simulator endpoint for ServiceNow should be created, so we can add some FT tests. Feel free to create an issue to do that, not really required for the PR, but would be happy to see it. Note the newly created issue in this PR.
@stephmilovic did you want this merged for 7.6? (sorry, I prolly already asked but can't find it ATM). I'd like another reviewer, but the usual reviewers won't be available till just before FF. I could round up someone else tho, LMK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just curious what you think about additional fields. If we don't need those, I think the server-side code is good to go.
It would be great if you could add this to the list of built-in types in actions/README.md with some docs on the parameters.
Do you intend to do the UI portion as well (as a separate PR, not here) ?
x-pack/legacy/plugins/actions/server/builtin_action_types/lib/post_servicenow.ts
Outdated
Show resolved
Hide resolved
@peterschretlen Thanks for the review! I am building out a Case Management workflow for SIEM, which will include third party integrations such as ServiceNow. As we are doing a little planning while developing, I only included the |
Discussed with @stephmilovic. It sounds like more incident fields will be taken into consideration later, but for the MVP only comments and short description are needed. We'll use the minimal set for now, add additional fields if/when needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Kibana's Actions Documentation moved here. |
Summary
Resolves #53891
Kibana action for posting new incidents to Service Now.
Testing instructions:
You will need an instance of ServiceNow. Either create your own, or @stephmilovic has an instance that falls asleep after 24 hours. Slack me if it has fallen asleep and I can wake it. The url and credentials for that instance are here.
POST http://localhost:5601/api/action
id
returned from your successful Kibana action POST to create a new service now incident.POST http://localhost:5601/api/action/123-the-kbn-action-id/_execute
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately