Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix codeowners for alerting services team #53889

Merged
merged 7 commits into from
Jan 15, 2020
Merged

Fix codeowners for alerting services team #53889

merged 7 commits into from
Jan 15, 2020

Conversation

mikecote
Copy link
Contributor

@mikecote mikecote commented Jan 2, 2020

I realized CODEOWNERS isn't working for the alerting services team. After comparing with other definitions, it seems each path needs to end with a / which I'm adding in this PR.

@mikecote mikecote added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Jan 2, 2020
@mikecote mikecote self-assigned this Jan 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote mikecote requested a review from a team January 2, 2020 13:42
@mikecote
Copy link
Contributor Author

mikecote commented Jan 2, 2020

@elasticmachine merge upstream

pmuellr
pmuellr approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; there were a few more that were missing trailing /s as well, should probably ask relevant folk if they want those fixed as well. Examples I noticed:

/src/dev/i18n @elastic/kibana-localization
/x-pack/legacy/plugins/telemetry @elastic/pulse

@mikecote
Copy link
Contributor Author

mikecote commented Jan 2, 2020

@elastic/kibana-localization & @elastic/pulse did you want me to fix these issues for you as well? In regards to comment #53889 (review).

@mikecote
Copy link
Contributor Author

mikecote commented Jan 3, 2020

@elasticmachine merge upstream

@TinaHeiligers
Copy link
Contributor

@elastic/kibana-localization & @elastic/pulse did you want me to fix these issues for you as well? In regards to comment #53889 (review).

@mikecote yes please.

@mikecote mikecote requested review from a team January 3, 2020 21:17
@mikecote
Copy link
Contributor Author

Hi @TinaHeiligers, let me know if the telemetry and localization changes I made look good to you 🙏 thanks!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Bamieh
Bamieh approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! lgtm

@mikecote mikecote merged commit 67a8194 into elastic:master Jan 15, 2020
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
@mikecote @elasticmachine @jkelastic
Fix codeowners for alerting services team (elastic#53889)
7ca9884 
* Fix codeowners

* Fix localization and telemetry folders as well

* Fix task manager path

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bamieh Bamieh Bamieh approved these changes

@pmuellr pmuellr pmuellr approved these changes

Assignees

@mikecote mikecote

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mikecote @elasticmachine @TinaHeiligers @kibanamachine @pmuellr @Bamieh