Add support for workspaces in NP x-pack plugins #53825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
💚 Build Succeeded
To update your PR or re-run it, just comment with: |
joshdover
force-pushed
the
np/workspaces
branch
from
b54de66 to
a975e76
Compare
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
mistic
approved these changes
Jan 7, 2020
joshdover
force-pushed
the
np/workspaces
branch
from
a975e76 to
74ce1ac
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Jan 10, 2020
joshdover
added a commit
that referenced
this pull request
Jan 13, 2020
Co-authored-by: Elastic Machine <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
infraplugin currently leverages Yarn Workspaces to install custom versions of some dependencies. This PR adds the necessary config to support the same workspaces in thex-pack/pluginsdirectory for New Platform plugins.Note, this does not add support for workspaces in OSS plugins. We do not currently support this in legacy OSS plugins either. I think we'd like to minimize usage of custom NPM module versions, so I'm not expanding support to OSS at this time.