Use savedObjects provided by the platform instead of legacy shim.
#53679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azasypkin
added
chore
Team:Security
|
Pinging @elastic/kibana-security (Team:Security) |
azasypkin
commented
Dec 20, 2019
| @@ -7,7 +7,7 @@ | |||
| import { LegacyAPI } from '../plugin'; | |||
|
|
|||
| export class SecurityAuditLogger { | |||
| constructor(private readonly auditLogger: LegacyAPI['auditLogger']) {} | |||
| constructor(private readonly getAuditLogger: () => LegacyAPI['auditLogger']) {} | |||
There was a problem hiding this comment.
note: made this to be similar to I've done in ESO plugin and also be able to instantiate this logger (and hence initialize Saved Objects wrappers) outside of registerLegacyAPI method.
azasypkin
force-pushed
the
issue-xxx-np-security
branch
from
0ca05ef to
0393fa7
Compare
azasypkin
commented
Dec 20, 2019
| authz, | ||
| legacyAPI: { savedObjects }, | ||
| }: SetupSavedObjectsParams) { | ||
| export function setupSavedObjects({ auditLogger, authz, savedObjects }: SetupSavedObjectsParams) { | ||
| const getKibanaRequest = (request: KibanaRequest | LegacyRequest) => |
There was a problem hiding this comment.
note: according to Rudolf we still need to keep this conversion code here as core doesn't do that for us even though typings for setClientFactory and addClientWrapper say opposite. It should be fixed soon and we can git rid of this function as well.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
legrego
approved these changes
Dec 20, 2019
|
7.x/7.6.0: 78d2362 |
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
savedObjectsprovided by the platform instead of legacy shim in Security plugin.