Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ml inference processor and APIs to console #53618

Merged

Conversation

benwtrent
Copy link
Member

@benwtrent benwtrent commented Dec 19, 2019

Summary

Adds new Machine Learning inference processor to Kibana Console.

Also adds new inference APIs generated from ES specs.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@benwtrent benwtrent added chore Feature:Console Dev Tools Console Feature Feature:Dev Tools v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Dec 19, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cjcenizal cjcenizal self-requested a review December 19, 2019 21:55
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and the autocomplete LGTM! Processor autocomplete worked well too:

image

However, it looks like when I hit any of these endpoints I get a 400 error. Am I doing something wrong? Or have I found a bug?

image

@cjcenizal
Copy link
Contributor

Were these endpoints added to ES very recently? If so then the 400 errors may be due to the pinned ES version being out of date, which is being addressed by #53645.

@benwtrent
Copy link
Member Author

@cjcenizal these endpoints are in 8.0.0 and 7.6.0 :). As for when the PR for the endpoints was merged, it was in the last month or so.

I have verified that the endpoint works on master.

Do you know the pinned commit hash? I could double check before merge if you are concerned.

@benwtrent
Copy link
Member Author

image

Seems to work for me :).

@benwtrent benwtrent merged commit ec4fca6 into elastic:master Dec 20, 2019
@benwtrent benwtrent deleted the feature/add-inference-to-dev-autocomplete branch December 20, 2019 17:14
benwtrent added a commit to benwtrent/kibana that referenced this pull request Dec 20, 2019
Adds new Machine Learning Inference processor to Kibana Console.

Also adds new Inference APIs generated from ES specs.
benwtrent added a commit that referenced this pull request Dec 20, 2019
Adds new Machine Learning Inference processor to Kibana Console.

Also adds new Inference APIs generated from ES specs.
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 8, 2020
Adds new Machine Learning Inference processor to Kibana Console.

Also adds new Inference APIs generated from ES specs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Console Dev Tools Console Feature Feature:Dev Tools release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants