NP Migration: Rollup plugin #53503

flash1293 · 2019-12-18T16:21:32Z

This PR includes shimming of the Rollup plugin.

Early stages WIP PR:

actually call shimmed plugin
~~[ ] convert to typescript~~ (moved to the Phase III)

Also here I got rid of injectI18n.

jloleysens · 2020-01-28T16:21:04Z

With regards to the issue: I am still able to reproduce it. I learned that this happens when specifying an index pattern like t* and a rollup index with a name like test. The error condition being that the rollup index will match itself.

The UI is specifically breaking because cause is not mapable. Looks like the cause variable is a string. @alisonelizabeth tested on master under the conditions described above and we should be seeing:

So it does look like a regression introduced here. Let me know if you need more info!

maryia-lapata · 2020-01-29T09:58:42Z

x-pack/legacy/plugins/rollup/public/search/rollup_search_strategy.ts

  id: 'rollup',

-  search: ({ searchRequests, Promise }) => {


I removed Promise because it isn't passed here any more
https://github.com/elastic/kibana/blob/master/src/plugins/data/public/search/search_strategy/types.ts#L35

jloleysens

Tested locally and am happy with the proposed changes overall. Left some non-blocker comments.

x-pack/legacy/plugins/rollup/public/plugin.tsx

maryia-lapata · 2020-01-29T10:32:04Z

@jloleysens finally I reproduced the issue. Thanks for explanation. It was caused by a mistake in the code (here).
I fixed it.

How it looks now:

On the screenshot a status code is displayed as well. It was already envisaged here.

# Conflicts: # x-pack/legacy/plugins/rollup/public/visualize/editor_config.js

lizozom

Didn't pull down to test.

@elastic/kibana-app-arch changes are 1 file

kibanamachine · 2020-01-30T07:35:30Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 29663bc

History

💔 Build #23324 failed 69675c0
💚 Build #23263 succeeded 09518e3
💚 Build #23251 succeeded cc80ce0
💚 Build #22986 succeeded 14ef013
💚 Build #22970 succeeded 32aa6fb

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Start shimming rollup plugin * continued shimming rollup ui * Remove unnecessarily return * Register management section * Replace ui/chrome * Replace ui/documentation_links * Replace ui/kfetch and ui/courier * Start shimming rollup plugin * continued shimming rollup ui * Remove unnecessarily return * Register management section * Replace ui/chrome * Replace ui/documentation_links * Replace ui/kfetch and ui/courier * Replace ui/notify * Move ui/ imports to legacy_imports.ts * Update NP mock for management * Refactoring * Read body from error object * Update setup_environment.js * Update unit tests * Get rid of injectI18n * Replace npStart and npSetup usage to services * Import search strategy stuff from the top level of the data plugin * Update unit tests * Do not prepend the url * Fix merge conflicts * Refactoring * Revert removal of setUserHasLeftApp * Export getSearchErrorType * Remove extra wrapper - Router * Fix cause prop. * Leave just static imports in legacy_imports.js * Add TS * Pass statusCode instead of statusText * Move template in a separate file * Move app register to setup * Add karma mock for management setup * Add EditorConfigProviderRegistry export Co-authored-by: Maryia Lapata <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Joe Reuter <[email protected]> Co-authored-by: Elastic Machine <[email protected]>

elasticmachine · 2020-02-10T09:33:56Z

Pinging @elastic/kibana-app (Team:KibanaApp)

Start shimming rollup plugin

96c8004

flash1293 added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Rollups Feature:NP Migration v7.6.0 labels Dec 18, 2019

This comment has been minimized.

Sign in to view

flash1293 and others added 7 commits December 20, 2019 16:35

Merge remote-tracking branch 'upstream/master' into migration/rollup

ab6d618

continued shimming rollup ui

ce83531

Merge branch 'master' into migration/rollup

0d6cdc9

Remove unnecessarily return

6dba8d4

Merge remote-tracking branch 'kibana/master' into migration/rollup

f257af1

Register management section

937297c

Replace ui/chrome

bd7df05

Merge remote-tracking branch 'kibana/master' into migration/rollup

1dcc987

maryia-lapata added v7.7.0 and removed v7.6.0 labels Jan 13, 2020

maryia-lapata and others added 12 commits January 13, 2020 14:04

Replace ui/documentation_links

f698766

Replace ui/kfetch and ui/courier

9612ec7

Start shimming rollup plugin

4336dce

continued shimming rollup ui

ec8730a

Remove unnecessarily return

339d013

Register management section

c0dfed8

Replace ui/chrome

518d580

Replace ui/documentation_links

d1233b4

Replace ui/kfetch and ui/courier

1e77e22

Replace ui/notify

79ee7c6

Move ui/ imports to legacy_imports.ts

b8c8dad

Update NP mock for management

b6f1f9e

maryia-lapata added 5 commits January 29, 2020 10:02

Merge branch 'master' into migration/rollup

8291fc4

Fix cause prop.

7000b9d

Leave just static imports in legacy_imports.js

6a2f72e

Add TS

aead81b

Pass statusCode instead of statusText

cc80ce0

maryia-lapata reviewed Jan 29, 2020

View reviewed changes

jloleysens approved these changes Jan 29, 2020

View reviewed changes

x-pack/legacy/plugins/rollup/public/plugin.tsx Outdated Show resolved Hide resolved

x-pack/legacy/plugins/rollup/public/plugin.tsx Outdated Show resolved Hide resolved

maryia-lapata added 4 commits January 29, 2020 14:29

Move template in a separate file

09518e3

Move app register to setup

7d702a7

Merge remote-tracking branch 'kibana/master' into migration/rollup

6e85464

# Conflicts: # x-pack/legacy/plugins/rollup/public/visualize/editor_config.js

Add karma mock for management setup

69675c0

lizozom approved these changes Jan 29, 2020

View reviewed changes

maryia-lapata added 2 commits January 30, 2020 09:15

Add EditorConfigProviderRegistry export

763e01d

Merge remote-tracking branch 'kibana/master' into migration/rollup

29663bc

maryia-lapata merged commit 0d03ade into elastic:master Jan 30, 2020

maryia-lapata mentioned this pull request Jan 30, 2020

[7.x] NP Migration: Rollup plugin (#53503) #56357

Merged

maryia-lapata added the backported label Jan 30, 2020

lukeelmers added a commit to lukeelmers/kibana that referenced this pull request Feb 3, 2020

Add AggTypeFilters, AggTypeFieldFilters from elastic#53503

6b32d2a

maryia-lapata added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Feb 10, 2020

alisonelizabeth mentioned this pull request Apr 11, 2020

[Rollups][ES-UI] No Error Message Shown for when Rollup Matches All Indices #63270

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NP Migration: Rollup plugin #53503

NP Migration: Rollup plugin #53503

flash1293 commented Dec 18, 2019 •

edited by maryia-lapata

Loading

This comment has been minimized.

jloleysens commented Jan 28, 2020

maryia-lapata Jan 29, 2020

jloleysens left a comment

maryia-lapata commented Jan 29, 2020

lizozom left a comment

kibanamachine commented Jan 30, 2020

elasticmachine commented Feb 10, 2020

NP Migration: Rollup plugin #53503

NP Migration: Rollup plugin #53503

Conversation

flash1293 commented Dec 18, 2019 • edited by maryia-lapata Loading

This comment has been minimized.

jloleysens commented Jan 28, 2020

maryia-lapata Jan 29, 2020

Choose a reason for hiding this comment

jloleysens left a comment

Choose a reason for hiding this comment

maryia-lapata commented Jan 29, 2020

lizozom left a comment

Choose a reason for hiding this comment

kibanamachine commented Jan 30, 2020

💚 Build Succeeded

History

elasticmachine commented Feb 10, 2020

flash1293 commented Dec 18, 2019 •

edited by maryia-lapata

Loading