-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs UI] HTTP API for log entry #53485
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afgomez
force-pushed
the
51047-log-entry-http-api
branch
from
December 18, 2019 15:21
af1c594
to
006488d
Compare
afgomez
added
Feature:Logs UI
Logs UI feature
release_note:skip
Skip the PR/issue when compiling release notes
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
v7.6.0
v8.0.0
labels
Dec 18, 2019
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Kerry350
approved these changes
Dec 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, nice work 👍
The merge conflict will likely be from the client side NP work, let me know if you need a hand.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
afgomez
pushed a commit
to afgomez/kibana
that referenced
this pull request
Dec 20, 2019
* Implement `log_entries/item` api * Use endpoint in the `useLogFlyout` hook * Clean up GraphQL implementation and types * Extract type for log entries cursor * fixup! Extract type for log entries cursor
afgomez
pushed a commit
that referenced
this pull request
Dec 20, 2019
* Implement `log_entries/item` api * Use endpoint in the `useLogFlyout` hook * Clean up GraphQL implementation and types * Extract type for log entries cursor * fixup! Extract type for log entries cursor Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Logs UI
Logs UI feature
release_note:skip
Skip the PR/issue when compiling release notes
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
v7.6.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated version of #52281. Implements an HTTP endpoint for an individual log item.
Part of #51047
Checklist
This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibility