Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] HTTP API for log entry #53485

Merged
merged 6 commits into from
Dec 20, 2019

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented Dec 18, 2019

Summary

Updated version of #52281. Implements an HTTP endpoint for an individual log item.

Part of #51047

Checklist

@afgomez afgomez force-pushed the 51047-log-entry-http-api branch from af1c594 to 006488d Compare December 18, 2019 15:21
@afgomez afgomez mentioned this pull request Dec 18, 2019
1 task
@afgomez afgomez added Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.6.0 v8.0.0 labels Dec 18, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@afgomez afgomez marked this pull request as ready for review December 18, 2019 15:31
@afgomez afgomez requested a review from a team as a code owner December 18, 2019 15:31
@Kerry350 Kerry350 self-requested a review December 19, 2019 10:52
Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, nice work 👍

The merge conflict will likely be from the client side NP work, let me know if you need a hand.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afgomez afgomez merged commit bb33aa2 into elastic:master Dec 20, 2019
@afgomez afgomez deleted the 51047-log-entry-http-api branch December 20, 2019 13:23
afgomez pushed a commit to afgomez/kibana that referenced this pull request Dec 20, 2019
* Implement `log_entries/item` api

* Use endpoint in the `useLogFlyout` hook

* Clean up GraphQL implementation and types

* Extract type for log entries cursor

* fixup! Extract type for log entries cursor
afgomez pushed a commit that referenced this pull request Dec 20, 2019
* Implement `log_entries/item` api

* Use endpoint in the `useLogFlyout` hook

* Clean up GraphQL implementation and types

* Extract type for log entries cursor

* fixup! Extract type for log entries cursor

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants