Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Add error state for unstructured logs #53299

Merged

Conversation

chrisronline
Copy link
Contributor

Resolves #53298

To test, configure filebeat to ingest unstructured logs and observe the new, specific error message.

Screen Shot 2019-12-17 at 10 31 48 AM

@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@DanRoscigno
Copy link
Contributor

Thanks for this @chrisronline I am going to do some testing with the default config of the module and see if the default filebeat/modules.d/elasticsearch.yml should have some tweaks.

Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline chrisronline merged commit 75447e5 into elastic:master Dec 17, 2019
@chrisronline chrisronline deleted the monitoring/unstructured_logs branch December 17, 2019 20:54
chrisronline added a commit to chrisronline/kibana that referenced this pull request Dec 17, 2019
* Add error state for unstructured logs

* Fix tests
chrisronline added a commit to chrisronline/kibana that referenced this pull request Dec 17, 2019
* Add error state for unstructured logs

* Fix tests
chrisronline added a commit that referenced this pull request Dec 18, 2019
* Add error state for unstructured logs

* Fix tests
chrisronline added a commit that referenced this pull request Dec 18, 2019
* Add error state for unstructured logs

* Fix tests
@chrisronline
Copy link
Contributor Author

Backport:

7.x: b9cbfcc
7.5: 3b16d3a

@timroes timroes added v7.5.2 and removed 7.5.2 labels Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Monitoring] Logs UI in stack monitoring doesn't handle unstructured logs
5 participants