[Maps] Move legend rendering to style property #53173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasneirynck
added
chore
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
thomasneirynck
force-pushed
the
chore/move_legend
branch
from
ab4fe17 to
8b36eb4
Compare
thomasneirynck
added
the
release_note:skip
|
@elasticmachine merge upstream |
thomasneirynck
changed the title
|
@elasticmachine merge upstream |
nreese
reviewed
Dec 17, 2019
There was a problem hiding this comment.
This PR is going to have lot of merge conflicts with #52957. That PR moves fetching of field formatters into the data request so they are sync when used during styling and setting feature state. Maybe we should get that pattern in before going forward with this PR
x-pack/legacy/plugins/maps/public/layers/styles/components/ranged_style_legend_row.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/styles/vector/properties/dynamic_color_property.js
Outdated
Show resolved
Hide resolved
…nc in vector_style
|
merged in #53311 locally. Needs to wait until that one merges. |
nreese
reviewed
Dec 18, 2019
x-pack/legacy/plugins/maps/public/layers/styles/vector/components/legend/vector_style_legend.js
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/styles/vector/vector_style.js
Outdated
Show resolved
Hide resolved
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Dec 18, 2019
thomasneirynck
added a commit
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves legend-row rendering down to style-property. This sets the stage for implementing different legend-row based on style-type (e.g. for categorical styling).
It also moves field-meta retrieval into the style-property, so field-meta can be used when syncing with mapbox (e.g. field-meta will be required to create categorical style filters)