Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/monitor list externel linking #53098

Merged

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Dec 16, 2019

Summary

Fixes: #52524

Refactored list of columns according to new design as well as moved integration inside drawer into button.

After:
image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@shahzad31 shahzad31 self-assigned this Dec 16, 2019
@shahzad31 shahzad31 marked this pull request as ready for review December 16, 2019 08:22
@shahzad31 shahzad31 added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Dec 16, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - resolve translations and WFG before merging

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 862265a into elastic:master Dec 18, 2019
@shahzad31 shahzad31 deleted the feature/monitor-list-externel-linking branch December 18, 2019 09:20
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Dec 18, 2019
* update monitor list columns

* update columns

* update snaps

* fix type

* removed unused ii8n
shahzad31 added a commit that referenced this pull request Dec 18, 2019
* update monitor list columns

* update columns

* update snaps

* fix type

* removed unused ii8n
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:enhancement Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Uptime] Monitor List Expanded Row -- External linking
3 participants