-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/monitor list externel linking #53098
Merged
shahzad31
merged 8 commits into
elastic:master
from
shahzad31:feature/monitor-list-externel-linking
Dec 18, 2019
Merged
Feature/monitor list externel linking #53098
shahzad31
merged 8 commits into
elastic:master
from
shahzad31:feature/monitor-list-externel-linking
Dec 18, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzad31
added
the
Team:Uptime - DEPRECATED
Synthetics & RUM sub-team of Application Observability
label
Dec 16, 2019
Pinging @elastic/uptime (Team:uptime) |
justinkambic
approved these changes
Dec 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - resolve translations and WFG before merging
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Dec 18, 2019
* update monitor list columns * update columns * update snaps * fix type * removed unused ii8n
shahzad31
added a commit
that referenced
this pull request
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:enhancement
Team:Uptime - DEPRECATED
Synthetics & RUM sub-team of Application Observability
v7.6.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #52524
Refactored list of columns according to new design as well as moved integration inside drawer into button.
After:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers