adds whitelisting to slack and pagerduty action types #52989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmmorris
added
Feature:Alerting
release_note:skip
gmmorris
commented
Dec 13, 2019
| }); | ||
| }); | ||
|
|
||
| describe('action is registered', () => { | ||
| test('gets registered with builtin actions', () => { |
There was a problem hiding this comment.
This is essentially an integration test and is covered by the function test suite
pmuellr
approved these changes
Dec 13, 2019
| @@ -0,0 +1,14 @@ | |||
| /* | |||
There was a problem hiding this comment.
hahaha I just created one of these for another PR!!!!
There was a problem hiding this comment.
It was the obvious refactor :)
YulNaumenko
approved these changes
Dec 13, 2019
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Dec 16, 2019
The Slack and Pagerduty actions currently do not do whitelist validation, this PR adds the requirement for the PD and Slack action's respective target URLs to also be whitelisted.
gmmorris
added a commit
that referenced
this pull request
Dec 17, 2019
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Slack and Pagerduty actions currently do not do whitelist validation, this PR adds the requirement for the PD and Slack action's respective target URLs to also be whitelisted.
closes #52301
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11This was checked for keyboard-only and screenreader accessibilityFor maintainers