-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Canvas] Adds functional test for Canvas custom elements #52920
[Canvas] Adds functional test for Canvas custom elements #52920
Conversation
Pinging @elastic/kibana-canvas (Team:Canvas) |
3eddfe6
to
b9a4243
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding more tests!
I added some comments about the test design and find/testSubjects usage.
|
||
// Close the modal | ||
await browser.pressKeys(browser.keys.ESCAPE); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not critical, but nice to wrap element search and interactions into "user-readable" functions. In this case, test scenario is easy to understand and support in the future.
it('deletes custom element when prompted', async () => {
await PageObjects.canvas.openCustomElementsTab();
await PageObjects.canvas.checkCustomElementsCount(1);
await PageObjects.canvas.deleteElementByIndex(0);
await PageObjects.canvas.checkCustomElementsCount(0);
}
Hey @poffdeluxe test logged error:
You can reproduce it by running:
|
d4f5e15
to
a30e28d
Compare
💚 Build Succeeded
History
To update your PR or re-run it, just comment with: |
a30e28d
to
02ac139
Compare
02ac139
to
3cda4a9
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Spoke with @dmlemeshko briefly over slack but I think for now we're gonna skip the tests on firefox if they're interactive. Something is going on with the firefox functional tests and clicking on the elements in the workpad. |
* Adds functional test for Canvas custom elements feedback cleanup * Opening up Canvas app first * Add skip firefox tag to custom element test
* Adds functional test for Canvas custom elements feedback cleanup * Opening up Canvas app first * Add skip firefox tag to custom element test
Summary
New functional test walks through the custom element life cycle: