Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move search bar to NP #52622

Merged
merged 21 commits into from
Dec 13, 2019
Merged

Move search bar to NP #52622

merged 21 commits into from
Dec 13, 2019

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Dec 10, 2019 •
edited
Loading

Summary

Solves #51028

Move search bar to NP
Remove left usages of indexPatterns angular service (as it was causing errors loading timelion app).

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@lizozom lizozom requested a review from a team as a code owner December 10, 2019 11:56
@lizozom lizozom self-assigned this Dec 10, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lizozom lizozom mentioned this pull request Dec 10, 2019
Closed
2 tasks
lukeelmers
lukeelmers reviewed Dec 12, 2019
View reviewed changes
src/plugins/data/public/types.ts Outdated Show resolved Hide resolved
src/plugins/data/public/ui/index.ts Outdated Show resolved Hide resolved
@lizozom lizozom mentioned this pull request Dec 12, 2019
Merged
7 tasks
lukeelmers
lukeelmers approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, once everything is green!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lizozom lizozom merged commit e3282d4 into elastic:master Dec 13, 2019
@lizozom lizozom mentioned this pull request Dec 13, 2019
Merged
lizozom pushed a commit to lizozom/kibana that referenced this pull request Dec 13, 2019
Move search bar to NP (elastic#52622)
92ccea5 
* Moved SearchBar component to NP

* move search bar to NP

* change import

* Revert "change import"

This reverts commit 52d990f.

* Revert "move search bar to NP"

This reverts commit 4196e8b.

* move create search bar

* Clean up jest mocks

* update snapshots

* Remove indexPatterns angular service

* Deleted comment

* Mock npStart.core.savedObjects

* Removed export of SearchBarOwnProps

* fix import

* Fix typo

* eslint
lizozom pushed a commit that referenced this pull request Dec 13, 2019
Move search bar to NP (#52622) (#52983)
9e1d91f 
* Moved SearchBar component to NP

* move search bar to NP

* change import

* Revert "change import"

This reverts commit 52d990f.

* Revert "move search bar to NP"

This reverts commit 4196e8b.

* move create search bar

* Clean up jest mocks

* update snapshots

* Remove indexPatterns angular service

* Deleted comment

* Mock npStart.core.savedObjects

* Removed export of SearchBarOwnProps

* fix import

* Fix typo

* eslint
@nreese nreese mentioned this pull request Dec 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeelmers lukeelmers lukeelmers approved these changes

Assignees

@lizozom lizozom

Labels
Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lizozom @elasticmachine @lukeelmers