Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs + Metrics UI] Add missing headers in Logs & metrics #52405

Merged
merged 4 commits into from
Dec 11, 2019
Merged

[Logs + Metrics UI] Add missing headers in Logs & metrics #52405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
94da3b2
Fix broken aria references
Dec 6, 2019
24c6d90
Fix `aria-labelledby` references in settings page
Dec 6, 2019
5a65895
Merge branch 'master' into 52371-accesibility-header-structure
elasticmachine Dec 10, 2019
9720ae9
Merge branch 'master' into 52371-accesibility-header-structure
Dec 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 30 additions & 20 deletions ...egacy/plugins/infra/public/components/source_configuration/fields_configuration_panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,12 @@ export const FieldsConfigurationPanel = ({
<EuiDescribedFormGroup
idAria="timestampField"
title={
<FormattedMessage
id="xpack.infra.sourceConfiguration.timestampFieldLabel"
defaultMessage="Timestamp"
/>
<h4>
<FormattedMessage
id="xpack.infra.sourceConfiguration.timestampFieldLabel"
defaultMessage="Timestamp"
/>
</h4>
}
description={
<FormattedMessage
Expand Down Expand Up @@ -95,10 +97,12 @@ export const FieldsConfigurationPanel = ({
<EuiDescribedFormGroup
idAria="tiebreakerField"
title={
<FormattedMessage
id="xpack.infra.sourceConfiguration.tiebreakerFieldLabel"
defaultMessage="Tiebreaker"
/>
<h4>
<FormattedMessage
id="xpack.infra.sourceConfiguration.tiebreakerFieldLabel"
defaultMessage="Tiebreaker"
/>
</h4>
}
description={
<FormattedMessage
Expand Down Expand Up @@ -140,10 +144,12 @@ export const FieldsConfigurationPanel = ({
<EuiDescribedFormGroup
idAria="containerField"
title={
<FormattedMessage
id="xpack.infra.sourceConfiguration.containerFieldLabel"
defaultMessage="Container ID"
/>
<h4>
<FormattedMessage
id="xpack.infra.sourceConfiguration.containerFieldLabel"
defaultMessage="Container ID"
/>
</h4>
}
description={
<FormattedMessage
Expand Down Expand Up @@ -185,10 +191,12 @@ export const FieldsConfigurationPanel = ({
<EuiDescribedFormGroup
idAria="hostNameField"
title={
<FormattedMessage
id="xpack.infra.sourceConfiguration.hostNameFieldLabel"
defaultMessage="Host name"
/>
<h4>
<FormattedMessage
id="xpack.infra.sourceConfiguration.hostNameFieldLabel"
defaultMessage="Host name"
/>
</h4>
}
description={
<FormattedMessage
Expand Down Expand Up @@ -230,10 +238,12 @@ export const FieldsConfigurationPanel = ({
<EuiDescribedFormGroup
idAria="podField"
title={
<FormattedMessage
id="xpack.infra.sourceConfiguration.podFieldLabel"
defaultMessage="Pod ID"
/>
<h4>
<FormattedMessage
id="xpack.infra.sourceConfiguration.podFieldLabel"
defaultMessage="Pod ID"
/>
</h4>
}
description={
<FormattedMessage
Expand Down
22 changes: 13 additions & 9 deletions ...gacy/plugins/infra/public/components/source_configuration/indices_configuration_panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,14 @@ export const IndicesConfigurationPanel = ({
</EuiTitle>
<EuiSpacer size="m" />
<EuiDescribedFormGroup
idAria="matricIndices"
idAria="metricIndices"
title={
<FormattedMessage
id="xpack.infra.sourceConfiguration.metricIndicesTitle"
defaultMessage="Metric indices"
/>
<h4>
<FormattedMessage
id="xpack.infra.sourceConfiguration.metricIndicesTitle"
defaultMessage="Metric indices"
/>
</h4>
}
description={
<FormattedMessage
Expand Down Expand Up @@ -90,10 +92,12 @@ export const IndicesConfigurationPanel = ({
<EuiDescribedFormGroup
idAria="logIndices"
title={
<FormattedMessage
id="xpack.infra.sourceConfiguration.logIndicesTitle"
defaultMessage="Log indices"
/>
<h4>
<FormattedMessage
id="xpack.infra.sourceConfiguration.logIndicesTitle"
defaultMessage="Log indices"
/>
</h4>
}
description={
<FormattedMessage
Expand Down
4 changes: 3 additions & 1 deletion .../legacy/plugins/infra/public/components/source_configuration/name_configuration_panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ export const NameConfigurationPanel = ({
<EuiDescribedFormGroup
idAria="name"
title={
<FormattedMessage id="xpack.infra.sourceConfiguration.nameLabel" defaultMessage="Name" />
<h4>
<FormattedMessage id="xpack.infra.sourceConfiguration.nameLabel" defaultMessage="Name" />
</h4>
}
description={
<FormattedMessage
Expand Down
10 changes: 6 additions & 4 deletions ...ages/logs/log_entry_rate/setup/initial_configuration_step/analysis_setup_indices_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,12 @@ export const AnalysisSetupIndicesForm: React.FunctionComponent<{
<EuiDescribedFormGroup
idAria="indices"
title={
<FormattedMessage
id="xpack.infra.analysisSetup.indicesSelectionTitle"
defaultMessage="Choose indices"
/>
<h3>
<FormattedMessage
id="xpack.infra.analysisSetup.indicesSelectionTitle"
defaultMessage="Choose indices"
/>
</h3>
}
description={
<FormattedMessage
Expand Down
10 changes: 6 additions & 4 deletions ...es/logs/log_entry_rate/setup/initial_configuration_step/analysis_setup_timerange_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,12 @@ export const AnalysisSetupTimerangeForm: React.FunctionComponent<{
<EuiDescribedFormGroup
idAria="timeRange"
title={
<FormattedMessage
id="xpack.infra.analysisSetup.timeRangeTitle"
defaultMessage="Choose a time range"
/>
<h3>
<FormattedMessage
id="xpack.infra.analysisSetup.timeRangeTitle"
defaultMessage="Choose a time range"
/>
</h3>
}
description={
<FormattedMessage
Expand Down