Cleanup alerting / actions feature controls #52286

mikecote · 2019-12-05T14:17:29Z

Resolves #51121.

This PR removes the alerting and action features from feature controls. Solution teams who want to use alerting will have to grant alerting privileges within their features as this PR does for SIEM.

Note: Granting alerting privileges at this time will allow full control of alerts created by any solution team. This will be solved with #43994.

Note: The alerting UI within the management section will have to look at multiple places to know whether to show or not. This will be solved with #52300 and if needed, we can automate this beforehand.

Example:

const canShowAlerting = capabilities.get().siem.showAlerting || capabilities.get().monitoring.showAlerting

elasticmachine · 2019-12-05T14:17:31Z

Pinging @elastic/kibana-stack-services (Team:Stack Services)

mikecote

Had a few questions about feature controls that I'm hoping someone on @elastic/kibana-security team can help me with 🙏

x-pack/legacy/plugins/siem/server/kibana.index.ts

x-pack/legacy/plugins/monitoring/server/plugin.js

elasticmachine · 2019-12-05T15:31:07Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 3a775ae

…nup-feature-controls

x-pack/legacy/plugins/siem/server/kibana.index.ts

mikecote · 2019-12-11T13:31:07Z

@elastic/stack-monitoring I'm not sure if you wanted alerting privileges granted on master with this PR or if you wanted to do it yourself? Let me know, the code necessary is here and easy to remove.

mikecote · 2019-12-11T13:38:12Z

@elasticmachine merge upstream

mikecote · 2019-12-11T13:58:15Z

cc @peterschretlen so you're aware of the changes for 7.6. Let me know if this doesn't align.

FrankHassanabad

Checked it out, ran a few test runs and everything still seems functional from the API standpoint, so I think we are good.

LGTM

…te/kibana into alerting/cleanup-feature-controls

pmuellr

code LGTM

chrisronline · 2019-12-11T21:32:15Z

@mikecote From a user perspective, what changes with this PR for stack monitoring? I pulled it down but don't see anything different in the spaces configuration.

mikecote · 2019-12-11T21:38:00Z

@mikecote From a user perspective, what changes with this PR for stack monitoring? I pulled it down but don't see anything different in the spaces configuration.

From a user perspective, nothing will change when it comes to managing roles / users. Though they will see the alert / actions management screens once the PR merges (#48959) if they have monitoring_user role granted.

mikecote · 2019-12-11T21:39:11Z

Also, you will see from a technical perspective the alerting APIs get disabled if you don't have monitoring or SIEM access.

YulNaumenko

LGTM

pmuellr · 2019-12-12T14:53:54Z

Also, you will see from a technical perspective the alerting APIs get disabled if you don't have monitoring or SIEM access.

Ya, that's slightly weird, but understandable.

Two things:

will this cause an issue in the future; will we have to change some of this stuff in a future release that would end up getting messy in terms of migration? I guess we don't know exactly what the future holds in terms of sub-/super-feature access stuff, and it also doesn't (from my n00b perspective) seem like anything we're doing here is future-problematic, but ... still a bit of a security n00b.
if we find a case where a customer wants to "play" with alerts/actions, but can't get access to siem or monitoring in their organization, is there an "out" so they can? Like, a new role could be created with the appropriate privileges to work with alerts/actions without siem or monitoring access? Kinda thing.

mikecote · 2019-12-12T15:27:34Z

will this cause an issue in the future; will we have to change some of this stuff in a future release that would end up getting messy in terms of migration? I guess we don't know exactly what the future holds in terms of sub-/super-feature access stuff, and it also doesn't (from my n00b perspective) seem like anything we're doing here is future-problematic, but ... still a bit of a security n00b.

I believe all features / privileges are calculated at run time so any change we do would automatically apply to the users on existing systems. This would mean once stop granting full alert object type access to certain features, users will stop having full control of alerts. cc @elastic/kibana-security just to confirm this is the case.

if we find a case where a customer wants to "play" with alerts/actions, but can't get access to siem or monitoring in their organization, is there an "out" so they can? Like, a new role could be created with the appropriate privileges to work with alerts/actions without siem or monitoring access? Kinda thing.

I think the future direction would be granting a default application to user defined alerts (ex: visualization). For that scenario, as long as users have access to visualizations, they would be able to use alerts.

chrisronline · 2019-12-12T18:33:40Z

@mikecote I don't think that'll be a problem. Should be fine

mikecote · 2019-12-12T19:47:02Z

@chrisronline last question I had was did you want this PR to enable alerting for Stack Monitoring or did you have it in a feature branch somewhere and want to enable it there instead?

chrisronline · 2019-12-12T19:51:37Z

to enable alerting for Stack Monitoring

What does that look like exactly? I guess I'm not sure what "enabling" means in this context? Make it a dependency on the plugin?

mikecote · 2019-12-12T20:04:20Z

What does that look like exactly? I guess I'm not sure what "enabling" means in this context? Make it a dependency on the plugin?

Me and @chrisronline discussed offline that I will remove monitoring related changes in this PR and it will be added within their feature branch of alerting.

…nup-feature-controls

kobelb · 2019-12-12T20:24:31Z

Did we release any versions with the alerting/actions features/privileges? Even if we did, we wouldn't break anything by removing them, but we might surprise users with them disappearing and then reappearing and users having privileges to them...

mikecote · 2019-12-12T20:28:27Z

@kobelb the 7.4 release introduced features (#41389) while also disabling the plugins by default in the same release (#44083). Only as of 7.6 we've enabled them back (#51254). Though 7.3 did have alerting saved objects / some APIs but nothing officially supported or with features.

kobelb · 2019-12-12T20:30:04Z

@kobelb the 7.4 release introduced features (#41389) while also disabling the plugins by default in the same release (#44083). Only as of 7.6 we've enabled them back (#51254). Though 7.3 did have alerting saved objects / some APIs but nothing officially supported or with features.

Thanks for the explanation, seems reasonable enough for us to just remove these features in this situation :)

elasticmachine · 2019-12-13T15:36:09Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: a0ffe3c

History

💚 Build #15251 succeeded 405dcee
💚 Build #14827 succeeded e1774af
💔 Build #14769 failed b908a70

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Initial work * Apply changes based on feedback * Fix a broken test * Fix failing test * Revert monitoring changes * Remove UI features for now

Initial work

3a775ae

mikecote added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Stack Services v7.6.0 labels Dec 5, 2019

mikecote self-assigned this Dec 5, 2019

mikecote commented Dec 5, 2019

View reviewed changes

x-pack/legacy/plugins/siem/server/kibana.index.ts Outdated Show resolved Hide resolved

x-pack/legacy/plugins/monitoring/server/plugin.js Outdated Show resolved Hide resolved

x-pack/legacy/plugins/monitoring/server/plugin.js Outdated Show resolved Hide resolved

mikecote added 3 commits December 6, 2019 10:59

Merge branch 'master' of github.com:elastic/kibana into alerting/clea…

c82cda1

…nup-feature-controls

Apply changes based on feedback

11567ba

Fix a broken test

bc81923

mikecote commented Dec 6, 2019

View reviewed changes

x-pack/legacy/plugins/siem/server/kibana.index.ts Outdated Show resolved Hide resolved

Merge with master

a6fbb93

mikecote marked this pull request as ready for review December 11, 2019 13:29

mikecote requested a review from a team as a code owner December 11, 2019 13:29

mikecote requested review from a team December 11, 2019 13:29

Merge branch 'master' into alerting/cleanup-feature-controls

b908a70

FrankHassanabad approved these changes Dec 11, 2019

View reviewed changes

mikecote added 2 commits December 11, 2019 11:02

Fix failing test

80a6c82

Merge branch 'alerting/cleanup-feature-controls' of github.com:mikeco…

e1774af

…te/kibana into alerting/cleanup-feature-controls

pmuellr approved these changes Dec 11, 2019

View reviewed changes

mikecote requested a review from YulNaumenko December 11, 2019 21:25

YulNaumenko approved these changes Dec 11, 2019

View reviewed changes

mikecote added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) and removed DONOTUSETeam:Stack Services labels Dec 12, 2019

mikecote added 2 commits December 12, 2019 15:19

Merge branch 'master' of github.com:elastic/kibana into alerting/clea…

70322e8

…nup-feature-controls

Revert monitoring changes

405dcee

mikecote removed the request for review from a team December 12, 2019 20:20

kobelb approved these changes Dec 12, 2019

View reviewed changes

Remove UI features for now

a0ffe3c

mikecote merged commit 88ae8d0 into elastic:master Dec 13, 2019

mikecote mentioned this pull request Dec 13, 2019

[7.x] Cleanup alerting / actions feature controls (#52286) #52999

Merged

mikecote added a commit that referenced this pull request Dec 13, 2019

Cleanup alerting / actions feature controls (#52286) (#52999)

236ca45

* Initial work * Apply changes based on feedback * Fix a broken test * Fix failing test * Revert monitoring changes * Remove UI features for now

mikecote mentioned this pull request Dec 18, 2019

Create UI for alerting and actions plugin #48959

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup alerting / actions feature controls #52286

Cleanup alerting / actions feature controls #52286

mikecote commented Dec 5, 2019 •

edited

Loading

elasticmachine commented Dec 5, 2019

mikecote left a comment

elasticmachine commented Dec 5, 2019

mikecote commented Dec 11, 2019

mikecote commented Dec 11, 2019

mikecote commented Dec 11, 2019

FrankHassanabad left a comment

pmuellr left a comment

chrisronline commented Dec 11, 2019

mikecote commented Dec 11, 2019

mikecote commented Dec 11, 2019 •

edited

Loading

YulNaumenko left a comment

pmuellr commented Dec 12, 2019

mikecote commented Dec 12, 2019

chrisronline commented Dec 12, 2019

mikecote commented Dec 12, 2019

chrisronline commented Dec 12, 2019

mikecote commented Dec 12, 2019

kobelb commented Dec 12, 2019 •

edited

Loading

mikecote commented Dec 12, 2019

kobelb commented Dec 12, 2019 •

edited

Loading

elasticmachine commented Dec 13, 2019

Cleanup alerting / actions feature controls #52286

Cleanup alerting / actions feature controls #52286

Conversation

mikecote commented Dec 5, 2019 • edited Loading

elasticmachine commented Dec 5, 2019

mikecote left a comment

Choose a reason for hiding this comment

elasticmachine commented Dec 5, 2019

💔 Build Failed

mikecote commented Dec 11, 2019

mikecote commented Dec 11, 2019

mikecote commented Dec 11, 2019

FrankHassanabad left a comment

Choose a reason for hiding this comment

pmuellr left a comment

Choose a reason for hiding this comment

chrisronline commented Dec 11, 2019

mikecote commented Dec 11, 2019

mikecote commented Dec 11, 2019 • edited Loading

YulNaumenko left a comment

Choose a reason for hiding this comment

pmuellr commented Dec 12, 2019

mikecote commented Dec 12, 2019

chrisronline commented Dec 12, 2019

mikecote commented Dec 12, 2019

chrisronline commented Dec 12, 2019

mikecote commented Dec 12, 2019

kobelb commented Dec 12, 2019 • edited Loading

mikecote commented Dec 12, 2019

kobelb commented Dec 12, 2019 • edited Loading

elasticmachine commented Dec 13, 2019

💚 Build Succeeded

History

mikecote commented Dec 5, 2019 •

edited

Loading

mikecote commented Dec 11, 2019 •

edited

Loading

kobelb commented Dec 12, 2019 •

edited

Loading

kobelb commented Dec 12, 2019 •

edited

Loading