-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing stateful saved object finder #52166
Merged
flash1293
merged 14 commits into
elastic:master
from
flash1293:remove-saved-object-finder
Dec 10, 2019
Merged
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6bbdddc
start removing stateful saved object finder
flash1293 a2fbc47
remove legacy saved object finder
flash1293 0c19145
Merge remote-tracking branch 'upstream/master' into remove-saved-obje…
flash1293 5a52169
fix unit test
flash1293 98ad3d2
Merge remote-tracking branch 'upstream/master' into remove-saved-obje…
flash1293 9447808
fix typings
flash1293 8b76153
Merge remote-tracking branch 'upstream/master' into remove-saved-obje…
flash1293 751a185
update snapshot
flash1293 f1dea23
Merge remote-tracking branch 'upstream/master' into remove-saved-obje…
flash1293 db4ae45
revert embeddable changes and create stateful wrapper on the boundaries
flash1293 9cf97d1
Merge remote-tracking branch 'upstream/master' into remove-saved-obje…
flash1293 39cb7d2
Merge remote-tracking branch 'upstream/master' into remove-saved-obje…
flash1293 146b3ab
fix uninitialized visualization app for wizard
flash1293 27ce33a
fix tests
flash1293 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 3 additions & 1 deletion
4
...ns/kibana/public/discover/components/top_nav/__snapshots__/open_search_panel.test.js.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
108 changes: 0 additions & 108 deletions
108
src/legacy/ui/public/saved_objects/components/saved_object_finder.tsx
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was introducing this wrapper component necessary, instead of just introducing two new props on the existing
SavedObjectFinder
component? Are there still places whereSavedObjectFinder
is used, withoutuiSettings
andsavedObjects
props?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not at the moment, but this is the target architecture we are moving towards (see also #52493 ). Passing
uiSettings
andsavedObjects
services down through the component tree can be cumbersome in some cases, so the wrapper component is able to pick it out of the Kibana context: https://github.com/elastic/kibana/tree/master/src/plugins/kibana_react#contextThe usages of saved object finder in embeddables will move into this direction soon. Future uses should be guided into this direction.