-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs UI] Add setup screen for the categorization tab #51905
[Logs UI] Add setup screen for the categorization tab #51905
Conversation
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
aeab6dd
to
1f2b081
Compare
1f2b081
to
0100fd4
Compare
cdcbf91
to
220811b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick pass. Monday I'll download the code and see it as a whole, but so far it looks very good <3
x-pack/legacy/plugins/infra/public/pages/logs/log_entry_rate/page_results_content.tsx
Show resolved
Hide resolved
...onents/logging/log_analysis_setup/initial_configuration_step/analysis_setup_indices_form.tsx
Outdated
Show resolved
Hide resolved
...ents/logging/log_analysis_setup/initial_configuration_step/analysis_setup_timerange_form.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/infra/public/containers/logs/log_analysis/log_analysis_setup_state.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
I like how everything is reused from the log entry. I think we can go even further down that path (maybe a different PR?), but I'm happy with it :)
x-pack/legacy/plugins/infra/public/pages/logs/log_entry_categories/page_setup_content.tsx
Show resolved
Hide resolved
x-pack/legacy/plugins/infra/public/pages/logs/log_entry_rate/use_log_entry_rate_setup.tsx
Show resolved
Hide resolved
@elastic/ml-ui does this look reasonable to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just suggested some possible edits to the descriptions used in the ML module and jobs.
x-pack/legacy/plugins/ml/server/models/data_recognizer/modules/logs_ui_categories/manifest.json
Outdated
Show resolved
Hide resolved
.../server/models/data_recognizer/modules/logs_ui_categories/ml/log_entry_categories_count.json
Outdated
Show resolved
Hide resolved
.../server/models/data_recognizer/modules/logs_ui_categories/ml/log_entry_categories_count.json
Outdated
Show resolved
Hide resolved
.../server/models/data_recognizer/modules/logs_ui_categories/ml/log_entry_categories_count.json
Show resolved
Hide resolved
@peteharverson I updated the descriptions |
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated descriptions LGTM
This adds the setup screen for the log entry categorization. closes elastic#50320 closes elastic#50414
Backports the following commits to 7.x: - [Logs UI] Add setup screen for the categorization tab (#51905)
Summary
This adds the setup screen for the log entry categorization.
closes #50320
closes #50414
Previews
Checklist
[ ] Documentation was added for features that require explanation or tutorials