Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] Add setup screen for the categorization tab #51905

Merged
merged 21 commits into from
Dec 18, 2019

Conversation

weltenwort
Copy link
Member

@weltenwort weltenwort commented Nov 29, 2019

Summary

This adds the setup screen for the log entry categorization.

closes #50320
closes #50414

Previews

grafik

grafik

Checklist

@weltenwort weltenwort added v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Nov 29, 2019
@weltenwort weltenwort self-assigned this Nov 29, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@weltenwort weltenwort force-pushed the logs-ui-categorization-add-setup branch from aeab6dd to 1f2b081 Compare December 11, 2019 10:37
@weltenwort weltenwort force-pushed the logs-ui-categorization-add-setup branch from 1f2b081 to 0100fd4 Compare December 11, 2019 17:50
@weltenwort weltenwort force-pushed the logs-ui-categorization-add-setup branch from cdcbf91 to 220811b Compare December 12, 2019 14:40
@elastic elastic deleted a comment from elasticmachine Dec 12, 2019
@elastic elastic deleted a comment from elasticmachine Dec 12, 2019
@weltenwort weltenwort marked this pull request as ready for review December 12, 2019 22:18
@weltenwort weltenwort requested review from a team as code owners December 12, 2019 22:18
@afgomez afgomez self-requested a review December 13, 2019 12:12
Copy link
Contributor

@afgomez afgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick pass. Monday I'll download the code and see it as a whole, but so far it looks very good <3

Copy link
Contributor

@afgomez afgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

I like how everything is reused from the log entry. I think we can go even further down that path (maybe a different PR?), but I'm happy with it :)

@weltenwort
Copy link
Member Author

@elastic/ml-ui does this look reasonable to you?

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just suggested some possible edits to the descriptions used in the ML module and jobs.

@weltenwort
Copy link
Member Author

@peteharverson I updated the descriptions

@spalger
Copy link
Contributor

spalger commented Dec 17, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated descriptions LGTM

@weltenwort weltenwort merged commit 8863fc2 into elastic:master Dec 18, 2019
@weltenwort weltenwort deleted the logs-ui-categorization-add-setup branch December 18, 2019 10:20
weltenwort added a commit to weltenwort/kibana that referenced this pull request Dec 18, 2019
This adds the setup screen for the log entry categorization.

closes elastic#50320 
closes elastic#50414
weltenwort added a commit that referenced this pull request Dec 18, 2019
Backports the following commits to 7.x:
 - [Logs UI] Add setup screen for the categorization tab (#51905)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logs UI] Add ML module with a common log categorization job [Logs UI] Add the log categories setup screen
6 participants