Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Allow routes to define some payload config values (#50783) #51864

Merged
merged 1 commit into from
Nov 28, 2019

Conversation

afharo
Copy link
Member

@afharo afharo commented Nov 28, 2019

Backports the following commits to 7.x:

* Allow routes to define some payload config values

* Documentation typo

* Move hapi `payload` config under `body` + additional validations

* Update API docs

* Amend explanation in API docs

* Add stream and buffer types to @kbn/config-schema

* Fixes based on PR feedback:
- Add 'patch' and 'options' to valid RouteMethod
- Add tests for all the new flags
- Allow `stream` and `buffer` schema in the body validations (findings from tests)

* API documentation update

* Fix type definitions

* Fix the NITs in the PR comments + better typing inheritance

* API docs update

* Fix APM-legacy wrapper's types

* Fix KibanaRequest.from type exposure of hapi in API docs

* Move RouterRoute interface back to private + Expose some public docs

* Update @kbn/config-schema docs
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@afharo afharo merged commit fe7a08c into elastic:7.x Nov 28, 2019
@afharo afharo deleted the backport/7.x/pr-50783 branch November 28, 2019 10:44
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 28, 2019
* upstream/7.x:
  Move saved queries service + language switcher ⇒ NP (elastic#51812) (elastic#51863)
  [Dependencies]: upgrade react to latest v16.12.0 (elastic#51145) (elastic#51868)
  Allow routes to define some payload config values (elastic#50783) (elastic#51864)
  [ML] Re-activate after method in transform test (elastic#51815) (elastic#51858)
  fixes pagination tests (elastic#51822) (elastic#51830)
  shim visualizations plugin (elastic#50624) (elastic#51801)
  [SIEM][Detection Engine] Change security model to use SIEM permissions (elastic#51848)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants